Add gio::Vfs subclass #1726
Add gio::Vfs subclass #1726
Conversation
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
63b4266 to
6427fa2
Compare
fbrouille
force-pushed
the
gio_vfs_subclass
branch
3 times, most recently
from
2484ba8 to
8a65537
Compare
|
Looks good to me except for the two open discussions about the string array. |
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
8a65537 to
ea7130d
Compare
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
ea7130d to
b831e69
Compare
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
b831e69 to
056b4a5
Compare
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
056b4a5 to
bcba69c
Compare
glib/src/collections/strv.rs
Outdated
| /// It can be constructed safely from a `&StrV` and unsafely from a pointer to a C array. | ||
| /// This type is very similar to `[GStringPtr]`, but with one added constraint: the underlying C array must be `NULL`-terminated. | ||
| #[repr(transparent)] | ||
| pub struct CStrV { |
There was a problem hiding this comment.
The name seems inconsistent with everything else. This is basically the String/PathBuf (StrV) vs. str/Path (CStrV) duality. Maybe this one should've actually been StrV and the other one StringV. Using Buf here seems wrong.
In other places (e.g. in gstreamer) there's a pattern of Foo and FooRef, so maybe we can just call this one StrVRef? @bilelmoussaoui what do you think?
Also GStringPtr is an ugly name, should probably reconsider that before the next release. Its difference with GStr is that it doesn't store the length and is equivalent with the raw C pointer. GStrLite or so... doesn't have to be solved as part of this PR but in case someone has ideas while we talk about naming anyway.
There was a problem hiding this comment.
CStrV because of std::ffi::CStr. However I agree that name should be consistent with others gtk-rs types. I think also that CStrV should be StrV and StrV should be StringV or if you don't want breaking changes, maybe renameCStrV to GStrV and rename StrV to GStringV and create a type alias (deprecated) StrV = GStringV.
Anyway let me know for CStrV new name.
There was a problem hiding this comment.
I'd still vote for StrV (stays as it is) and StrVRef. But waiting for @bilelmoussaoui to opine :)
There was a problem hiding this comment.
StrvRef / Strv sounds good to me
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
bcba69c to
c333df3
Compare
This type represents a borrowed reference to a `NULL`-terminated array of `NULL`-terminated UTF-8 strings. Signed-off-by: fbrouille <[email protected]>
Signed-off-by: fbrouille <[email protected]>
fbrouille
force-pushed
the
gio_vfs_subclass
branch
from
c333df3 to
7cf9052
Compare
Allow custom implementation of gio::Vfs