Skip to content

Conversation

@carlosthe19916
Copy link
Collaborator

@carlosthe19916 carlosthe19916 commented May 14, 2025

This PR revamps the Importer List Page:

  • Renamed Importers by Data sources.- it should be more intuitive to understand it
  • Replaced the old Table by a Data List.- a DataList allows us to render more information within the same column
  • SortBy is part of the Toolbar

What problems are we addressing:

  • We need to see the status of the last Execution within the Row. (First left icon should tell the status of the last execution)
    • The old page requires the User to expand the table to see the latest execution
  • We need to see how many documents the last execution ingested, just like when it finished and how long the execution lasted.
Screencast.From.2025-05-14.14-58-46.mp4

carlosthe19916 and others added 18 commits May 12, 2025 10:34
Signed-off-by: Carlos Feria <[email protected]>
# Conflicts:
#	client/src/app/App.css
#	client/src/app/api/model-utils.ts
#	client/src/app/client/index.ts
#	client/src/app/client/types.gen.ts
#	client/src/app/components/ConfirmDialog.tsx
#	client/src/app/components/FilterPanel/SearchFilterControl.tsx
#	client/src/app/components/FilterToolbar/DateRangeFilter.tsx
#	client/src/app/components/FilterToolbar/MultiselectFilterControl.tsx
#	client/src/app/components/FilterToolbar/SelectFilterControl.tsx
#	client/src/app/components/StateError.tsx
#	client/src/app/components/markdownPFComponents.tsx
#	client/src/app/components/notes-markdown.tsx
#	client/src/app/layout/about.tsx
#	client/src/app/layout/header.tsx
#	client/src/app/layout/sidebar.tsx
#	client/src/app/pages/advisory-details/advisory-details.tsx
#	client/src/app/pages/package-details/package-details.tsx
#	client/src/app/pages/sbom-details/sbom-details.tsx
#	client/src/app/pages/search/components/SearchMenu.tsx
#	client/src/app/pages/search/search.tsx
#	client/src/app/pages/upload/components/upload-file.tsx
#	client/src/app/pages/upload/upload.tsx
#	client/src/app/pages/vulnerability-details/vulnerability-details.tsx
#	client/src/app/utils/utils.ts
#	client/src/stories/v2.1/pages/search.tsx
#	client/src/stories/v2.1/product-list.stories.tsx
#	client/src/stories/v2.1/product-wizard.stories.tsx
#	package-lock.json
Signed-off-by: Carlos Feria <[email protected]>
Signed-off-by: Carlos Feria <[email protected]>
Signed-off-by: Carlos Feria <[email protected]>
# Conflicts:
#	client/src/app/pages/importer-list/importer-list.tsx
Signed-off-by: Carlos Feria <[email protected]>
Signed-off-by: Carlos Feria <[email protected]>
Signed-off-by: Carlos Feria <[email protected]>
# Conflicts:
#	client/src/app/utils/utils.ts
Signed-off-by: Carlos Feria <[email protected]>
# Conflicts:
#	client/src/app/pages/importer-list/importer-list.tsx
#	client/src/app/utils/utils.ts
Signed-off-by: Carlos Feria <[email protected]>
@carlosthe19916 carlosthe19916 added the needs-backport Indicates a PR needs to be backported label Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.27%. Comparing base (9d94f09) to head (20cf6cd).
⚠️ Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
client/src/app/components/PageDrawerContext.tsx 20.00% 4 Missing ⚠️
client/src/app/utils/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   54.34%   54.27%   -0.08%     
==========================================
  Files         145      145              
  Lines        2346     2353       +7     
  Branches      547      547              
==========================================
+ Hits         1275     1277       +2     
- Misses        873      878       +5     
  Partials      198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	client/src/app/Routes.tsx
#	client/src/app/layout/sidebar.tsx
@carlosthe19916
Copy link
Collaborator Author

Closing this PR as there are no plans to change our current Importers page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Indicates a PR needs to be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant