chore: add sbom_node - node_id index #2131
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dahsboard is calling some endpoints and one of them is using a big rust function that contains the following `select`: ```sql SELECT "sbom_node"."sbom_id", "sbom_node"."node_id", "sbom_node"."name" FROM "sbom_node" WHERE "node_id" = ANY($1) ``` This is the worse query that is making dashboard page slow because the table is big and the index is not getting a hit because `node_id` is part of a composite index (with position 2) and consequently not using cache.
Contributor
Reviewer's GuideAdds a dedicated single-column index on sbom_node.node_id via a new SeaORM migration to optimize a frequently used dashboard query, and wires the migration into the global migrator sequence. ER diagram for sbom_node and new node_id indexerDiagram
sbom_node {
int sbom_id
int node_id
string name
}
sbom_node_node_id_index {
int node_id
}
sbom_node ||--o{ sbom_node_node_id_index : indexed_by
Architecture/flow diagram for migration sequence with sbom_node_node_id_indexflowchart TD
subgraph MigrationRunner
A[MigrationRunner start]
B[m0001180_expand_spdx_licenses_with_mappings_function]
C[m0001190_optimize_product_advisory_query]
D[m0001200_source_document_fk_indexes]
E[m0001210_sbom_node_node_id_index]
F[MigrationRunner end]
end
A --> B --> C --> D --> E --> F
subgraph Database
T[sbom_node table]
I[sbom_node.node_id index]
end
E --> I
T -. uses .-> I
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- If sbom_node is large in production, consider using a concurrent index creation (or equivalent non-blocking option in SeaORM) to avoid long locks during the migration.
- The #[allow(deprecated)] on the Migration impl seems unnecessary here; consider removing it unless there is a specific deprecated API being used.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If sbom_node is large in production, consider using a concurrent index creation (or equivalent non-blocking option in SeaORM) to avoid long locks during the migration.
- The #[allow(deprecated)] on the Migration impl seems unnecessary here; consider removing it unless there is a specific deprecated API being used.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
- Coverage 68.09% 68.08% -0.02%
==========================================
Files 372 373 +1
Lines 20758 20763 +5
Branches 20758 20763 +5
==========================================
+ Hits 14135 14136 +1
+ Misses 5782 5780 -2
- Partials 841 847 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/scale-test |
|
🛠️ Scale test has started! Follow the progress here: Workflow Run |
Goose ReportGoose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
📄 Full Report (Go to "Artifacts" and download report) |
gildub
approved these changes
Nov 25, 2025
Contributor
gildub
left a comment
gildub
left a comment
There was a problem hiding this comment.
This LGTM.
The migration worked fine.
I cannot tell any improvement performance-wise regarding the dashboard as my current test set doesn't have big SBOMs volumes.
Contributor
Author
|
@gildub thanks for the review. I'm a bit afraid of introducing new indexes tbqh |
Contributor
Author
|
Folks I remember that I asked if we had scale tests for it and then I found this comment: This comment #2039 (comment) from Dejan says that
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dahsboard is calling some endpoints and one of them is using a big rust function that contains the following
select:This is the worse query that is making dashboard page slow because the table is big and the index is not getting a hit because
node_idis part of a composite index (with position 2) and consequently not using cache.Summary by Sourcery
Add a database migration to improve lookup performance on sbom_node by indexing node_id.
Enhancements:
EDIT:
https://gist.github.com/helio-frota/f821493c83a2c62c248f321d5e2c738b