Skip to content

Add Snyk workflow - #698

Merged
jacobwinch merged 4 commits into
mainfrom
jw-snyk
Feb 28, 2022
Merged

jacobwinch merged 4 commits into
mainfrom
jw-snyk

Conversation

@jacobwinch

@jacobwinch jacobwinch commented Feb 18, 2022

Copy link
Copy Markdown
Contributor

What does this change?

This PR uses the department-wide Snyk workflow, which helps us to identify vulnerabilities that would be missed by the current integration. This is because the former uses the Snyk cli, whereas the latter relies on the GitHub integration, which is not particularly accurate for sbt projects.

Whilst working on this, we noticed that .nvmrc was in a slightly odd place, so it's been moved to the project root as part of this change.

@jacobwinch
jacobwinch marked this pull request as ready for review February 25, 2022 09:59
@jacobwinch
jacobwinch requested a review from a team February 25, 2022 09:59
Comment thread .github/workflows/snyk.yaml Outdated
@jacobwinch
jacobwinch merged commit e51819f into main Feb 28, 2022
@jacobwinch
jacobwinch deleted the jw-snyk branch February 28, 2022 09:18
@jacobwinch

Copy link
Copy Markdown
Contributor Author

I've now deleted the project that was using the GitHub integration, so that we have a single project in Snyk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants