Football mini match stats component #14947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
force-pushed
the
jm/football-stats-mini
branch
from
1c67a32 to
985cf1c
Compare
jamesmockett
commented
Dec 3, 2025
| return ( | ||
| <div css={containerCss}> | ||
| <div css={[headerCss, raiseLabelOnDesktop && raiseLabelCss]}> | ||
| <span css={labelCss}>{label}</span> |
Contributor
Author
There was a problem hiding this comment.
It might make sense for this to be a heading? (Although the heading level would need to be configurable as it can appear in different places.)
jamesmockett
commented
Dec 3, 2025
Comment on lines
+79
to
+85
| <span css={buttonTextCss}>More stats, line-ups and tables</span> | ||
| <span css={buttonTextShortCss}>Stats and line ups</span> |
Contributor
Author
There was a problem hiding this comment.
I've hardcoded the button labels for now, but this could be made configurable later if needed
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
commented
Dec 3, 2025
Comment on lines
+93
to
+94
| raiseLabelOnDesktop?: boolean; | ||
| largeNumbersOnDesktop?: boolean; |
Contributor
Author
There was a problem hiding this comment.
I don't love these prop names so I'm open to suggestions
jamesmockett
force-pushed
the
jm/football-stats-mini
branch
from
a2bb58f to
c042bad
Compare
jamesmockett
force-pushed
the
jm/football-stats-mini
branch
from
a976989 to
bf48cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
FootballMiniMatchStatsand constituentFootballMatchStatcomponents.Why?
To enable the display of key match statistics in football match live blogs in DCAR (#14898). The
FootballMatchStatcomponent will also be used in the new match summary page (#14904).Screenshots