Draft - Add product carousel #14968
Draft
Draft - Add product carousel #14968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initial build of the card + a storybook - trying to ruse the product card buttons which required an override to be added as we want a different label on the button
… the page when wired up - Additional tweaks so the card is more aligned with the Figma designs - Added logic when there is no heading to put the product and brand name under the image on seperate lines - Added logic to handle when the product/brand name is longer than one line and needs to wrap - Using the ProductCardImage instead of Picture for consistency across these elements but happy to change it back again or discuss further - Added more storybooks
oliverabrahams
commented
Dec 4, 2025
| products: ProductBlockElement[]; | ||
| format: ArticleFormat; | ||
| }) => { | ||
| const fixedWidthOverrides: FixedWidthOverride[] = [ |
Contributor
Author
There was a problem hiding this comment.
Add a default width for the card / make mobile the default here
oliverabrahams
commented
Dec 4, 2025
Comment on lines
180
to
+185
| const generateCarouselColumnStyles = ( | ||
| totalCards: number, | ||
| visibleCarouselSlidesOnMobile: number, | ||
| visibleCarouselSlidesOnTablet: number, | ||
| ) => { | ||
| fixedCardWidthOverrides?: FixedWidthOverride[], | ||
| ): SerializedStyles[] | SerializedStyles => { |
Contributor
Author
There was a problem hiding this comment.
Could use different functions here depending on if we are using card width or card fractions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
Screenshots