Fix Slack thread transfer context sync#758
Closed
gugu91 wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing as duplicate/superseded by #757. I compared #757 against this backup PR. #757 covers the material fix here (broker transfer metadata includes Slack source/channel, follower runtime hydrates transferred Slack context before A2A delivery) and adds useful visible recovery guidance / Validation for #758 was clean, but #757 should be the coordinated lane for #756. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #756
Root cause
transfer_thread_idupdated broker ownership state, but the A2A assignment only carried the Slack thread timestamp. Follower runtime classifies A2A messages separately from normal Slack inbox entries, so workers never persisted the Slack channel/source context needed byslack_send/Pinet Slack delivery. Once ownership was explicitly transferred, broker-side relays correctly failed with "already owned by another agent", leaving broker and worker without a usable visible-thread reply path.Validation
pnpm vitest run slack-bridge/helpers.test.ts slack-bridge/pinet-mesh-ops.test.tspnpm lintpnpm typecheckpnpm testpnpm lint && pnpm typecheck && pnpm testsuccessfullyPR author/account: gugu91