Feat: Coding standards and unit tests.#162
Open
mgiannopoulos24 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Περιγραφή
Το PR προσθέτει:
main_lib.phpphpcs.xmlκαιphpunit.xmlconfiguration files.Περισσότεροι κανόνες για τα 2 configuration files:
Σχετικό issue
Issue #140
Τρόπος χρήσης (χειροκίνητα)
phpcs:./vendor/bin/phpcs --standard=phpcs.xml file/dir_of_choice # e.g. index.phpphpcbf(code beautifier - fixer)Σημείωση: Κάποια λάθη δεν είναι αυτόματα fixable.
./vendor/bin/phpcbf --standard=phpcs.xml file/dir_of_choice # e.g. index.phpphpunitΣημειώσεις
Προς το παρόν τα unit test καλύπτουν μόνο κάποιες συναρτήσεις χωρίς χρήση βάσης. Για να καλυφθούν και συναρτήσεις βάσης θα χρειαστούν αλλαγές.
Μελλοντικές βελτιώσεις
Σε κάποιο επόμενο PR θα προσθέσω E2E tests με Playwright. Κάνουν simulate την συμπεριφορά ενός χρήστη στην ιστοσελίδα. Άλλη μία καλή προσθήκη θα ήταν το PHPStan για static analysis.