Add permissions for publishing JUnit report #10169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
added
the
ready
|
Note that for reviewdog, we follow the other path, and use annotations instead. The linked doc indicates that this action also supports creating annotations for failed tests: with:
annotate_only: true # forked repo cannot write to checks so just do annotations |
|
Annotations are great if the annotated files are part of the PR (always the case with checkstyle), but I'm not sure it's possible to use them in case of failing unit tests that didn't change (which is the case for most? test failures). |
|
That's a great point - and it looks like stack traces are lost in annotations too: mikepenz/action-junit-report#1278 |
niloc132
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on suggestion in https://github.com/mikepenz/action-junit-report?tab=readme-ov-file#pr-run-permissions
Recent PRs marked as
readyrun the JUnit step, but are missing the report because of permissions. This PR should fix that.