Code formatting with clang-format#28
Draft
dwRchyngqxs wants to merge 1 commit into
Draft
Conversation
gyunaev
reviewed
Aug 31, 2024
gyunaev
left a comment
Owner
There was a problem hiding this comment.
You can add .clang-format but generally I don't like the huge changes which just do the formatting.
Author
|
Yeah, it's almost impossible to make sure nothing was sneaked in these huge commits. Could either be done by a trusted maintainer or a bot (I don't think you're using bots though). |
e568918 to
80caca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that code style is inconsistent and some questionable practices are in place (aligning fields with tabs is a no no as not every text editor uses the same tab length).
Fixing it all manually is a time consuming and needlessly tedious task. I propose the use of a code formatter to keep the style consistent.
I chose the clang-format style "Microsoft" as it seems the closest to what is in the code-base.
Maybe clang-format is not the best tool. According to the Qt doc it is one of the tools proposed by the Qt editor so I though it would be a good candidate.
Tell me what you think of this.