Tetris v2.0#12
Open
napstergit1 wants to merge 3 commits into
Open
Conversation
Из проблем на данный момент: 1) Нужно показывать следующую фигуру 2) Исправить код стайл 3) Проверить код на наличие лишнего "мусора" 4) Корректно обрабатывать проигрыш(сейчас немного не в тот момент срабатывает сигнал)
Исправлены замечания. Корректное отображение следующей фигуры, очков и всего что необходимо по заданию.
hBuzzy
reviewed
Dec 5, 2023
Comment on lines
+173
to
+174
|
|
||
|
|
| spawnNextFigure(); | ||
| SetFigurePosition(0, columnsNumber_ / 2); | ||
| CheckLine(); | ||
| bool HasCollision = HasCollisionMove(1, 0); |
| void GameOver(); | ||
|
|
||
| public: | ||
| void SetNextFigureGrid(QVector<QVector<int>> fig); |
Owner
There was a problem hiding this comment.
Не сокращайте названия fig -> figure
Comment on lines
+10
to
+11
|
|
||
|
|
| QVector<QVector<int>> nextFigure_; | ||
| int blockSize_; | ||
|
|
||
| Tetramino *tetr_; |
|
|
||
| QVector<QVector<int>> GetNextFigure(); | ||
| signals: | ||
| void nextFigureChanged(); |
Owner
There was a problem hiding this comment.
Сигналы, как и методы со слотами - с большой буквы
| Tetramino::~Tetramino() {} | ||
|
|
||
| void Tetramino::SetRandomFigure() { | ||
| int randNumb = 1 + rand() % 7; |
Исправлены замечания
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.