feature: nickname disambiguation #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nogaems
force-pushed
the
nickname_disambiguation
branch
4 times, most recently
from
21fe443 to
f6ac280
Compare
nogaems
force-pushed
the
nickname_disambiguation
branch
from
ee56d07 to
fe55894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a feature #19 I've faced a problem of not being able to have two+ identical nicknames due to the internal representation of WeeChat's
nicklist(i.e.struct t_gui_nick *weechat_nicklist_search_nick(...)always returns a single pointer and prefixes don't change anything).I've managed to get a user Tox ID's public key part via the API like you've mentioned previously, so I just basically put it (shortened version, using option
tox.look.short_id_size) in front of nicknames so that all the nicknames are different now. Also I had to implement the nickname completion because of that. The displaying of short ids in chat logs and presence messages may be disabled usingtox.look.show_id.clang-formatis already applied.On top of this feature I can finally finish #19 in a proper way.