-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFC Card #301
NFC Card #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Please put your project sources into the "src" folder. They should be two .JSON files, one from the schematic tab, one from the PCB tab.
Also, your exported PDF needs to be from the schematic tab, not the PCB tab.
Your cart.png look good to me though, and I love the design!
Hello, thank you so much for the feedback. Although, I am having a bit of
trouble on how to get the two .JSON files
…On Thu, Jan 4, 2024 at 8:16 PM Karmanyaah Malhotra ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi! Please put your project sources
<https://docs.easyeda.com/en/Export/Export-EasyEDA-Source-File/index.html>
into the "src" folder. They should be two .JSON files, one from the
schematic tab, one from the PCB tab.
Also, your exported PDF needs to be from the schematic tab, not the PCB
tab.
Your cart.png look good to me though, and I love the design!
—
Reply to this email directly, view it on GitHub
<#301 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFDBPZAQYNEZEXEEKAO4T7DYM5IADAVCNFSM6AAAAABBMILV26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBVGIZDOMZTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Actually I believe I did it. Whenever you are free, may you check it.
Best Wishes- Neel Patel
…On Thu, Jan 4, 2024 at 8:48 PM Neel Patel ***@***.***> wrote:
Hello, thank you so much for the feedback. Although, I am having a bit of
trouble on how to get the two .JSON files
On Thu, Jan 4, 2024 at 8:16 PM Karmanyaah Malhotra <
***@***.***> wrote:
> ***@***.**** requested changes on this pull request.
>
> Hi! Please put your project sources
> <https://docs.easyeda.com/en/Export/Export-EasyEDA-Source-File/index.html>
> into the "src" folder. They should be two .JSON files, one from the
> schematic tab, one from the PCB tab.
>
> Also, your exported PDF needs to be from the schematic tab, not the PCB
> tab.
>
> Your cart.png look good to me though, and I love the design!
>
> —
> Reply to this email directly, view it on GitHub
> <#301 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BFDBPZAQYNEZEXEEKAO4T7DYM5IADAVCNFSM6AAAAABBMILV26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBVGIZDOMZTG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
I think you uploaded the PCB.pdf again, the pdf file needs to be from the schematic tab, like this one |
I am really sorry about that mistake. I have fixed it. The PDF is called
Schematic_USB project_2023=01-06.pdf. Also, I don't really know how to
delete the PCB.pdf file so is it fine if they can just stay there.
Best Wishes- Neel Patel
…On Fri, Jan 5, 2024 at 11:43 PM Karmanyaah Malhotra < ***@***.***> wrote:
I think you uploaded the PCB.pdf again, the pdf file needs to be from the
schematic tab, like this one
<https://github.com/hackclub/OnBoard/blob/main/projects/Alex%20P's%20NFC%20Card/schematic.pdf>
—
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFDBPZGRDSWXE62ODHTUAV3YNDI6BAVCNFSM6AAAAABBMILV26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGU2DONBQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Have you filled out the verification form? If you already have, np, just waiting on that to get approved |
Hey I was wondering if there is anyone else I need to talk to so I can get
the second approval for the PCB card thing.
…-Neel Patel
On Tue, Jan 9, 2024 at 1:03 AM Karmanyaah Malhotra ***@***.***> wrote:
cc @sarthaktexas <https://github.com/sarthaktexas>
—
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFDBPZFZHVLHGGROGLXPU4TYNTMU5AVCNFSM6AAAAABBMILV26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSGQ3DCMZSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@TheSaltTable you've filled out the airtable form from the PR right? |
Yes, I did.
…On Fri, Jan 12, 2024 at 5:50 PM Karmanyaah Malhotra < ***@***.***> wrote:
@TheSaltTable <https://github.com/TheSaltTable> you've filled out the
airtable form
<https://airtable.com/app4Bs8Tjwvk5qcD4/pagxECjJZOgvKVnLd/form> from the
PR right?
—
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFDBPZHACLW7QWKTUBEYNVLYOG445AVCNFSM6AAAAABBMILV26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGA4DGNJUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! sent rn
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboard
channel on SlackI made this board from scratch, even if I followed a tutorial
I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
(Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩