-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexander Lee's Pull Request #331
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
You can view a render of your board over on tracespace.io! Happy OnBoarding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE THIS IDEA!!!!
Small blocker, just like your upload your PCB_PCB.json file, please File > Export > EasyEDA a JSON from the Schematic tab of your project.
This is not a requirement, but there are definitely ways to optimize your design to fit it in <$100; I don't know whether you can achieve that with your competition timeline.
Cost saving suggestions (there are more, these are just the few things that stood out to me, feel free to ask questions on Slack):
Just a suggestion though, if you replace the ESP32 module with an ESP32-SOLO-1, you might be able to save a lot of money. Right now your ESP32 S2 module is forcing you to use Standard Assembly, which adds like $20 to your assembly cost. I don't know how practical this is in your application, so this is just a suggestion that you may or may not want to take.
Here are also a few notes to get basically free money:
- These few capacitors are all "Extended parts". This means that it costs $3 extra per part for JLCPCB to grab these.
In your schematic, you can replace these with generic capacitors with an equivalent value, and they should work the same.
- Same thing applies to these transistors.
You can go to https://jlcpcb.com/parts. Search "transistor", and select the "Basic parts" checkbox.
- And buttons are the same as transistors
cc @Hugoyhu review circuit things plz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy Alex! I'm approving your student verification :)
@shadow2418889 lmk if there's any way I can help you get your grant sooner! |
HI! Sorry for the late reply. @shadow2418889 let me know if you'd like a schematic / routing review. |
@Hugoyhu A review would be greatly appreciated! Any tips on how I could improve my design for the future would also be nice. Thank you all, Alexander |
@shadow2418889 can you upload your schematic .json to the /src folder? Thank you |
I uploaded the export from EasyEda. Thank you all again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all and sorry for the wait. Currently checking your schematic. Few things:
- On U2 (CP2102N-28) why is RXD and TXD swapped? I'm referencing the Adafruit CP2102N-24 Friend.
- Should VREGIN be connected to 3.3V? SiLabs datasheet says 3.6-5,25 per fig 2.2
I will take a look at the other portions of this sch soon, thse two are issues taht pop out to me for the USB-serial portion.
Hi Hugo, For RXD and TXD swappage I was just following the schematics the ESPRESSIF M-1 Devkit: The VREGIN connection also comes from the ESPRESSIF M-1 Devkit Thanks, Alexander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently reading the datasheet for TPS62745 here: it seems your VSEL pins are connected to VOUT and not GND.
There's also a newer part TI recommends with "smaller size, better efficiency" which might be ideal for your battery-powered project: TPS629203
I'll take a looka t your motor drivers next (nice part selection! Fun coincidence, we were looking at these for our Blot machine). I'll make a comment when I am done checking that part.
For the previous comment RE CP2102N and etc: I have checked against the Espressif schematic and it seems OK. If you followed that then it should be good and I don't immediately see any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this for now. Please look at Hugo's comments to make sure your robot will work. Your grant should be sent soon (ping @sarthaktexas)! Please DM @ Sarthak Mohanty on Slack to figure out adding the amount over $100.
Thank you all! I finished the changes and I'll talk to Sarthak. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more or less OK for the schematic and well put together. I don't see any issues for DRV8833 against datasheet. Habve you run DRC on your PCB?
Oh, one note on PCB. Do you paln on using the BT / WiFi for ESP32? If so, the module should be on the edge of the PCB. at the very least, the area under the antenna section should have no copper fill, and at best, there should be a cutout or the antenna on module extends out. |
I was gonna play with Bluetooth control but it wasn't really vital for the project. Thanks for letting me know, ill probably update the design to better support wireless connectivity sometime in the future. |
Submission Checklist:
I am a current high school, middle school, or home schooled student.
I have joined the
#onboard
channel on SlackI made this board from scratch, even if I followed a tutorial
I have followed the directions in README.md
onboard/projects
TEMPLATE.md
asREADME.md
(Optional) This project is from a tutorial1.
(Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: 125
Footnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩