Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexander Lee's Pull Request #331

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Alexander Lee's Pull Request #331

merged 11 commits into from
Feb 12, 2024

Conversation

shadow2418889
Copy link
Contributor

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #onboard channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md
    • Uploaded Gerber, sources, and schematic
    • Uploaded screenshot of PCB order with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [n/a] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: 125

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Jan 29, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

You can view a render of your board over on tracespace.io!

Happy OnBoarding!

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE THIS IDEA!!!!

Small blocker, just like your upload your PCB_PCB.json file, please File > Export > EasyEDA a JSON from the Schematic tab of your project.

This is not a requirement, but there are definitely ways to optimize your design to fit it in <$100; I don't know whether you can achieve that with your competition timeline.

Cost saving suggestions (there are more, these are just the few things that stood out to me, feel free to ask questions on Slack):
Just a suggestion though, if you replace the ESP32 module with an ESP32-SOLO-1, you might be able to save a lot of money. Right now your ESP32 S2 module is forcing you to use Standard Assembly, which adds like $20 to your assembly cost. I don't know how practical this is in your application, so this is just a suggestion that you may or may not want to take.

Here are also a few notes to get basically free money:

  1. These few capacitors are all "Extended parts". This means that it costs $3 extra per part for JLCPCB to grab these.
    image In your schematic, you can replace these with generic capacitors with an equivalent value, and they should work the same.
    image
  2. Same thing applies to these transistors.
    image You can go to https://jlcpcb.com/parts. Search "transistor", and select the "Basic parts" checkbox.
  3. And buttons are the same as transistors
    image

cc @Hugoyhu review circuit things plz?

@karmanyaahm karmanyaahm added the Submission New Boards! label Jan 29, 2024
Copy link
Member

@sarthaktexas sarthaktexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy Alex! I'm approving your student verification :)

@karmanyaahm
Copy link
Member

@shadow2418889 lmk if there's any way I can help you get your grant sooner!

@Hugoyhu Hugoyhu self-requested a review February 3, 2024 15:52
@Hugoyhu
Copy link
Contributor

Hugoyhu commented Feb 3, 2024

HI! Sorry for the late reply. @shadow2418889 let me know if you'd like a schematic / routing review.

@shadow2418889
Copy link
Contributor Author

@Hugoyhu A review would be greatly appreciated! Any tips on how I could improve my design for the future would also be nice. Thank you all, Alexander

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Feb 3, 2024

@shadow2418889 can you upload your schematic .json to the /src folder? Thank you

@shadow2418889
Copy link
Contributor Author

I uploaded the export from EasyEda. Thank you all again.

Copy link
Contributor

@Hugoyhu Hugoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all and sorry for the wait. Currently checking your schematic. Few things:

I will take a look at the other portions of this sch soon, thse two are issues taht pop out to me for the USB-serial portion.

@shadow2418889
Copy link
Contributor Author

Hi Hugo,
First of all, thank you for your help and I'm completely fine about the delay.

For RXD and TXD swappage I was just following the schematics the ESPRESSIF M-1 Devkit:
image
and Feranec's tutorial https://youtu.be/S_p0YV-JlfU?t=2161. Honestly, I have no idea why the inputs are swapped, but I trust the schematic and Feranec.

The VREGIN connection also comes from the ESPRESSIF M-1 Devkit
image
While I am outside the recommended voltage, the datasheet states that the CP2102N can handle an input voltage 3V, so uh, I guess I can pray that it works out fine.

Thanks, Alexander

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently reading the datasheet for TPS62745 here: it seems your VSEL pins are connected to VOUT and not GND.

There's also a newer part TI recommends with "smaller size, better efficiency" which might be ideal for your battery-powered project: TPS629203

I'll take a looka t your motor drivers next (nice part selection! Fun coincidence, we were looking at these for our Blot machine). I'll make a comment when I am done checking that part.

For the previous comment RE CP2102N and etc: I have checked against the Espressif schematic and it seems OK. If you followed that then it should be good and I don't immediately see any problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for an output of 3.3v, so I just followed the recommended schematics:
image
JLCPCB doesn't have any TPS629203 in stock unfortunately.

Copy link
Member

@karmanyaahm karmanyaahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this for now. Please look at Hugo's comments to make sure your robot will work. Your grant should be sent soon (ping @sarthaktexas)! Please DM @ Sarthak Mohanty on Slack to figure out adding the amount over $100.

@karmanyaahm karmanyaahm merged commit 7143f0a into hackclub:main Feb 12, 2024
1 check passed
@shadow2418889
Copy link
Contributor Author

Thank you all! I finished the changes and I'll talk to Sarthak.

Copy link
Contributor

@Hugoyhu Hugoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more or less OK for the schematic and well put together. I don't see any issues for DRV8833 against datasheet. Habve you run DRC on your PCB?

@Hugoyhu
Copy link
Contributor

Hugoyhu commented Feb 14, 2024

Oh, one note on PCB. Do you paln on using the BT / WiFi for ESP32? If so, the module should be on the edge of the PCB. at the very least, the area under the antenna section should have no copper fill, and at best, there should be a cutout or the antenna on module extends out.

@shadow2418889
Copy link
Contributor Author

I was gonna play with Bluetooth control but it wasn't really vital for the project. Thanks for letting me know, ill probably update the design to better support wireless connectivity sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants