Skip to content

Conversation

@BananaJeanss
Copy link

Adds an /revoked page to display all revoked keys along with revocation date, and updated dashboard to only show recently (7 days ago) revoked keys.

Why? Keeps the dashboard looking clean (especially if you have a lot of revoked keys for some reason), and gives the revokedAt column a use (since I didn't see it used anywhere right now afaik).

/dashboard /revoked
image image

…ly (7 days) revoked keys

Adds an /revoked page to display all revoked keys along with revocation date, and updated dashboard to only show recently (7 days ago) revoked keys
Copy link
Contributor

@DragonSenseiGuy DragonSenseiGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, though the final merge up to mahad

@SkyfallWasTaken
Copy link
Member

Thanks for the PR, but I think the best move here is really to just hide revoked API keys entirely (as the site now does), I don't particularly see the need to see your revoked API keys at this time.

@BananaJeanss
Copy link
Author

Thanks for the PR, but I think the best move here is really to just hide revoked API keys entirely (as the site now does), I don't particularly see the need to see your revoked API keys at this time.

Imo I think being able to see revoked keys would be good just in case someone gets access to another's account somehow, and starts making and then later revoking keys without the actual account owner noticing. Sounds good anyways tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants