Skip to content

Baconpad #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Baconpad #631

wants to merge 13 commits into from

Conversation

BaconWaffleDonut
Copy link

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[✓] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[✓] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[✓] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[✓] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[✓] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[✓] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 1:31am

@nathantsai1
Copy link
Contributor

Hi @BaconWaffleDonut,

I'd love to see your hackpad, but the pictures don't seem to be working. Please change this.

@UnusualTitan711x
Copy link
Contributor

UnusualTitan711x commented Mar 12, 2025

Hi there,
Please add images to your hackpad.
Also, I noticed that your case parts don't have any label. Please add the name of your hackpad (or your own name) somewhere at the bottom so that it can be identified during printing.
Here is my PR: #405
Use it as a reference if you want

@BaconWaffleDonut
Copy link
Author

I labeled the case parts and added images differently than previously.

@UnusualTitan711x
Copy link
Contributor

I don't know why I still se 404 error. Did you try dragging and dropping the image into the README.md file?
Also, you have another empty README in your Firmware folder

)
]

keyboard.keymap = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your firmware seems incomplete? To me, this looks like you accidentally deleted a few lines after this. Please complete this so its valid Python.

The problem with the images in your README is most likely a Github problem, and it works if you view it directly in the repo: BaconWaffleDonut/hackpad1 - hackpads/bacons hackpad/README.md

@BaconWaffleDonut
Copy link
Author

I think that I fixed the code by moving the macro list directly into that. I also deleted the extra README in the firmware folder.

@Gamer153
Copy link
Contributor

I approve of this submission! Here's my own approved PR link: #443

@return-misaPuding
Copy link
Contributor

my PR is #634 , the only problem i see (assuming you fixed the firmware and just didn´t push it, the current version still has an unclosed bracket in keyboard.keymap = [) is the way your rotencs are wired:
since they share the same SW1, SWA, SWB labels for the MCU, they are indistinguishable by the firmware, so you can only set the functions as if you had 1 rotenc.
since you only have 1 free pin, this is not an easy fix, the best you could do is adding a SW2 label for the second rotenc - it will still share the rotate actions, but pressing it will be another button.

@return-misaPuding
Copy link
Contributor

return-misaPuding commented Mar 14, 2025

also, regarding the firmware, you don´t seem to have initialised your matrix - checking another submission, you need a from kmk.scanners.keypad import MatrixScanner. you also need 2 arrays of pins, in your case that´s COLPIN = [board.D1, board.D2, board.D4] and ROWPIN = [board.D26, board.D27] i think?
you then set up the matrix with

keyboard.matrix = MatrixScanner(
    rows=ROWPIN,
    cols=COLPIN,
    value_when_pressed=False,  # Adjust if necessary
)

you also need to set diode_orientation to COL2ROW.
your keymap then becomes

[[owo, uwu],
[colon, angy],
[KC.A, KC.B]]

with an EncoderHandler (which you need to import) for you 1 functional encoder

@Daamin909
Copy link
Member

Daamin909 commented Apr 3, 2025

I dont think having a 100% working firmware is a necessity, its not really possible to make a working one without the actual hackpad.
LGTM, my PR: #534

@return-misaPuding
Copy link
Contributor

fair enough, i approve then (PR #634 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants