-
Notifications
You must be signed in to change notification settings - Fork 448
Baconpad #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Baconpad #631
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'd love to see your hackpad, but the pictures don't seem to be working. Please change this. |
Hi there, |
I labeled the case parts and added images differently than previously. |
I don't know why I still se 404 error. Did you try dragging and dropping the image into the README.md file? |
) | ||
] | ||
|
||
keyboard.keymap = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your firmware seems incomplete? To me, this looks like you accidentally deleted a few lines after this. Please complete this so its valid Python.
The problem with the images in your README is most likely a Github problem, and it works if you view it directly in the repo: BaconWaffleDonut/hackpad1 - hackpads/bacons hackpad/README.md
fixed main.py code
deleted redundant README
I think that I fixed the code by moving the macro list directly into that. I also deleted the extra README in the firmware folder. |
I approve of this submission! Here's my own approved PR link: #443 |
my PR is #634 , the only problem i see (assuming you fixed the firmware and just didn´t push it, the current version still has an unclosed bracket in |
also, regarding the firmware, you don´t seem to have initialised your matrix - checking another submission, you need a
you also need to set diode_orientation to COL2ROW.
with an EncoderHandler (which you need to import) for you 1 functional encoder |
I dont think having a 100% working firmware is a necessity, its not really possible to make a working one without the actual hackpad. |
fair enough, i approve then (PR #634 ) |
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[✓] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[✓] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[✓] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[✓] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[✓] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[✓] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!