This repository was archived by the owner on Jul 6, 2019. It is now read-only.
SPI on STM32F4 + example #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: update AltMode enum in pin.rs. |
There was a problem hiding this comment.
Can you please use placement ioregs ( SPI @ <address> ) in here and get rid of extern block below?
There was a problem hiding this comment.
Would this mean duplicate memory tree for each SPIx?
There was a problem hiding this comment.
Hm. Actually yes, I'll fix it.
|
A refactor would surely be welcome from someone who has good understanding of STM MCUs, I'm absolutely willing to give up that tree for maintenance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reused code from stm32l1, adapted it and wrote an new example. More testing is needed.
There was also a typo (copy/paste) bug in peripheral_clock.rs.
Maybe a refactor should be done to factorize common code between stm32 mcus. Are there any plans regarding this?