Add JIRA webhook secret handling and update tests for webhook calls#145
Closed
ToxicBiohazard wants to merge 4 commits intohackthebox:mainfrom
Closed
Add JIRA webhook secret handling and update tests for webhook calls#145ToxicBiohazard wants to merge 4 commits intohackthebox:mainfrom
ToxicBiohazard wants to merge 4 commits intohackthebox:mainfrom
Conversation
- Updated the codebase to use Jira Webhook v2
Contributor
Author
|
Unsure, why it failed. I've forgotten to add the variable name in the .test.env file |
dimoschi
requested changes
Apr 10, 2025
Contributor
dimoschi
left a comment
There was a problem hiding this comment.
The webhook_call function is now too specific, while it should remain as generic as possible.
Contributor
Author
|
This PR is not needed. I learned later that the password can be appended to the end of the URL as per webhook v2.0. Apologies, for the inconvenience this may have caused. |
Contributor
|
No worries @ToxicBiohazard this is something new! Thanks for taking care of it in the first place! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
Updated the codebase to use Jira Webhook v2. As Jira Webhook v1 will be deprecated.
Checklist
Put an
xin the boxes that apply.doc.