Skip to content

Add JIRA webhook secret handling and update tests for webhook calls#145

Closed
ToxicBiohazard wants to merge 4 commits intohackthebox:mainfrom
ToxicBiohazard:jira-webhook-v2-modifications
Closed

Add JIRA webhook secret handling and update tests for webhook calls#145
ToxicBiohazard wants to merge 4 commits intohackthebox:mainfrom
ToxicBiohazard:jira-webhook-v2-modifications

Conversation

@ToxicBiohazard
Copy link
Copy Markdown
Contributor

@ToxicBiohazard ToxicBiohazard commented Apr 10, 2025

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Updated the codebase to use Jira Webhook v2. As Jira Webhook v1 will be deprecated.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

- Updated the codebase to use Jira Webhook v2
@ToxicBiohazard
Copy link
Copy Markdown
Contributor Author

Unsure, why it failed. I've forgotten to add the variable name in the .test.env file

Copy link
Copy Markdown
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webhook_call function is now too specific, while it should remain as generic as possible.

@ToxicBiohazard ToxicBiohazard requested a review from dimoschi April 17, 2025 06:47
Copy link
Copy Markdown
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToxicBiohazard
Copy link
Copy Markdown
Contributor Author

This PR is not needed. I learned later that the password can be appended to the end of the URL as per webhook v2.0. Apologies, for the inconvenience this may have caused.

@dimoschi
Copy link
Copy Markdown
Contributor

No worries @ToxicBiohazard this is something new! Thanks for taking care of it in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants