Added logging for certificate verification when linked and added testing#178
Merged
dimoschi merged 3 commits intohackthebox:mainfrom Apr 3, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 61.74% 62.10% +0.35%
==========================================
Files 50 50
Lines 2941 2953 +12
==========================================
+ Hits 1816 1834 +18
+ Misses 1125 1119 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dimoschi
reviewed
Mar 24, 2026
dimoschi
requested changes
Apr 2, 2026
Contributor
dimoschi
left a comment
There was a problem hiding this comment.
Good feature overall — the audit logging is a useful addition and the tests are well-structured. Two things to address before merging:
- The channel send needs its own
try/except(see inline). As-is, a Discord API failure on the log message will be misreported as a role assignment error and cause an incorrect failure response to the webhook caller, even though the role was already applied.account.pyhas the right pattern. - Missing test for the
verify_channel = Nonepath — one uncovered line flagged by Codecov.
…ests for when channel is None
dimoschi
approved these changes
Apr 3, 2026
Contributor
dimoschi
left a comment
There was a problem hiding this comment.
@janssensjelle thanks for addressing my comments. The PR looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
Sends a message to the verification channel of saying which user used which cert id
Checklist
Put an
xin the boxes that apply.doc.
Additional context
Add any other context or screenshots here.