fix for https://github.com/haml/haml/issues/486 - indentation issue on comments #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diregard this pull request. I missed a commit. |
|
Apparently I don't know how pull requests worked. My commit was added! Sorry for the noise. |
norman
added a commit
that referenced
this pull request
Jun 13, 2012
fix for haml/haml#486 - indentation issue on comments
|
No worries. Thanks! |
|
@snatchev Actually it looks like this broke some tests - could you have a look? |
|
Those were testing for the bug fix, so it looks like my missing commit actually broke them. Pull request sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have fixed the cause of this bug haml/haml#486.
What has happening was that erubis was stripping out the content of comments
<%# some comment %>and passing"\n"to ERB#add_stmt. Haml's add_stmt would then perform all 3 appending operations:https://github.com/haml/html2haml/blob/master/lib/html2haml/html/erb.rb#L62-64
This lead to a haml:block getting opened after the comment.