Skip to content

[IMP]Improved the gc_error method with the ORM #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[IMP]Improved the gc_error method with the ORM #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions security_workshop_demo/models/security_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import logging
import base64
from datetime import timedelta

from odoo import api, models, fields, _

_logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -37,21 +39,17 @@ def log_message(self, endpoint, message):
'path': '',
'line': 1,
})
self.env.cr.commit()

@api.autovacuum
def _gc_error(self):
self.gc_error('security.demo')
self.gc_error()

def gc_error(self, name):
def gc_error(self):
"""Garbage collect old logs securely."""
query = ("""
DELETE FROM ir_logging
WHERE create_date < (NOW() AT TIME ZONE 'UTC' - INTERVAL '7 DAYS')
AND name = %s
""" % name)
self.env.cr.execute(query)
_logger.info("GC'd %d security error logger entries", self.env.cr.rowcount)
cutoff = fields.Datetime.now() - timedelta(days=7)
old_logs = self.search([('create_date', '<', cutoff)])
if old_logs:
old_logs.unlink()

def _request(self, endpoint, params):
"""Dummy request handler (extend for real API calls)."""
Expand Down