fix: replace deprecated unload event with pagehide for Chrome 120+#329
Open
frank-ih wants to merge 1 commit intohangwin:masterfrom
Open
fix: replace deprecated unload event with pagehide for Chrome 120+#329frank-ih wants to merge 1 commit intohangwin:masterfrom
frank-ih wants to merge 1 commit intohangwin:masterfrom
Conversation
Chrome 120+ blocks window.addEventListener('unload') via Permissions Policy,
causing "Permissions policy violation: unload is not allowed" errors.
This replaces 'unload' with 'pagehide' in both element-picker and quick-panel
content scripts, which provides equivalent cleanup functionality while
remaining compatible with Chrome's stricter permissions policy.
Fixes the error:
"Permissions policy violation: unload is not allowed in this document"
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.addEventListener('unload', ...)withpagehidein content scriptsProblem
Chrome 120+ blocks
window.addEventListener('unload')via Permissions Policy, causing:Solution
Use
pagehideevent instead - provides equivalent cleanup functionality while remaining compatible with Chrome's stricter permissions policy.Files Changed
app/chrome-extension/entrypoints/element-picker.content.tsapp/chrome-extension/entrypoints/quick-panel.content.tsTesting