preparing to PR #1
Conversation
| </script> | ||
|
|
||
| <style> | ||
| @keyframes ldio-3igtohkgnvp-r { |
There was a problem hiding this comment.
3igtohkgnvp - ?
You can clean up your code when copy, and use scoped styles to isolate these classes within current component
| props: { | ||
| value: String, | ||
| }, | ||
| model: { |
There was a problem hiding this comment.
Not very convenient way when you work with simple inputs - you need to extract DOM node to emit new value
| this.todo = this.selectedTodo; | ||
| }, | ||
| methods: { | ||
| closeEditing() { |
There was a problem hiding this comment.
Redundant method. Just write @close=$emit('close')
| <th scope="col">Title</th> | ||
| <th scope="col">Completed</th> | ||
| <th scope="col"> | ||
| <button class="btn btn-info" @click="addNew">Add new +</button> |
| v-if="selectedTodo" | ||
| v-model="selectedTodo" | ||
| @close="closeEditing" | ||
| :key="selectedTodo.id"/> |
There was a problem hiding this comment.
What for did you add key here ?
| }, | ||
| addNew() { | ||
| this.todos.push({ |
There was a problem hiding this comment.
No backend communication in app
| <meta name="viewport" content="width=device-width,initial-scale=1.0"> | ||
| <link rel="icon" href="<%= BASE_URL %>favicon.ico"> | ||
| <title><%= htmlWebpackPlugin.options.title %></title> | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900" rel="stylesheet"> |
There was a problem hiding this comment.
import in css modules better
| @@ -0,0 +1,5 @@ | |||
| export default { | |||
| getCard(state) { | |||
There was a problem hiding this comment.
getter name should be a noun
| } | ||
| return state.todoList.filter((item) => item.title.includes(state.searchValue)); | ||
| }, | ||
| selectedTodo(state) { |
There was a problem hiding this comment.
Seems like this should be stored in a component, not in a store
No description provided.