Codegen javadoc enhancement, compare with getallmodels-description branch #3
Conversation
…dummy description when both summary and description are empty
haolingdong-msft
changed the title
| * @param input The input parameter. Allowed values: "value1", "value2". | ||
| * @param input . Allowed values: "value1", "value2". |
There was a problem hiding this comment.
We probably want "The input parameter. Allowed values: "value1", "value2"." here.
The ". Allowed .." likely added by codegen. Swagger prorbably have no description on this param.
There was a problem hiding this comment.
Thanks for the catch! I'm fixing.
There was a problem hiding this comment.
Fixed in 7b1bc2e
| * @param model I am root, and I ref a model with no meta. | ||
| * @param model The model parameter. |
There was a problem hiding this comment.
As long as this is what Swagger defines, this should be fine.
There was a problem hiding this comment.
The change is because we don't fallback to param's schema's description. So default description is generated.
There was a problem hiding this comment.
The change is because we don't fallback to param's schema's description. So default description is generated.
I am asking you to at least check 1 or 2 places in https://github.com/Azure/autorest.testserver/blob/main/swagger, that this assertion is true.
impacts: