Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from milvus-io:master #57

Open
wants to merge 1,126 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 29, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Aug 29, 2024
chyezh and others added 29 commits December 19, 2024 15:20
miss the patch due to code branching
previous pr: #38032

Signed-off-by: Congqi Xia <[email protected]>
Co-authored-by: Wei Liu <[email protected]>
When delete by partition_key, Milvus will generates L0 segments
globally. During L0 Compaction, those L0 segments will touch all
partitions collection wise. Due to the false-positive rate of segment
bloomfilters, L0 compactions will append false deltalogs to completed
irrelevant partitions, which causes *partition deletion amplification.

This PR uses partition_key to set targeted partitionID when producing
deleteMsgs into MsgStreams. This'll narrow down L0 segments scope to
partition level, and remove the false-positive influence
collection-wise.

However, due to DeleteMsg structure, we can only label one partition to
one deleteMsg, so this enhancement fails if user wants to delete over 2
partition_keys in one deletion.

See also: #34665

Signed-off-by: yangxuan <[email protected]>
Related to #31293

- Rename `UsingDatabase` to `UseDatabase`
- Uncomment default value methods
- Add missing RBAC APIs
- Add some resource group APIs

---------

Signed-off-by: Congqi Xia <[email protected]>
enhance: field stringtype maxlength raise to 1M
issue: #37436

Signed-off-by: Xianhui.Lin <[email protected]>
Update Knowhere Commit
Signed-off-by: sre-ci-robot [email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update Knowhere Commit
Signed-off-by: sre-ci-robot [email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issue: #36621

* add collection detail page
* enhance query page segments & channels state display

Signed-off-by: mimo.oyn <[email protected]>
Bump milvus version to v2.5.0
Signed-off-by: sre-ci-robot [email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fix altercollectionfield interceptor dbname 
issue: #37436

Signed-off-by: Xianhui.Lin <[email protected]>
related issue: #38471

---------

Signed-off-by: yanliang567 <[email protected]>
Signed-off-by: sre-ci-robot <[email protected]>
issue: #36621

* enhance collection detail page list columns
* enhance query page segments state detail logic

Signed-off-by: mimo.oyn <[email protected]>
issue: #38399

---------

Signed-off-by: chyezh <[email protected]>
ThreadDao and others added 30 commits January 23, 2025 14:29
issue: #33419 
- Add test cases for database properties
- Fixed typo AlterDatabaseProperies to AlterDatabaseProperties
- Rename UsingDatabase to UseDatabase
- Rename ListDatabases to ListDatabase

Signed-off-by: ThreadDao <[email protected]>
When there are many segment tasks in the querycoord scheduler, the
traversal in `GetSegmentTaskDelta` checks becomes time-consuming. This
PR adds caching for segment deltas.

issue: #37630

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Wei Liu <[email protected]>
Previously the grep with regex does not work and failed to match lots of
.cpp files

This PR:
- use "-E" flag to use regex match
- commit the fixed result of current cpp code

Signed-off-by: Congqi Xia <[email protected]>
/kind improvement

---------

Signed-off-by: laurazhao0611 <[email protected]>
Co-authored-by: laurazhao0611 <[email protected]>
/kind improvement

Signed-off-by: zhuwenxing <[email protected]>
The error message was malformated or missing some meta info, say field
name. This PR recitfies some message format and add field name in error
message when type param check fails.

---------

Signed-off-by: Congqi Xia <[email protected]>
Bump milvus version to v2.5.4
Signed-off-by: sre-ci-robot [email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
)

issue: #37630

Reduce the frequency updating metrics to avoid holding the mutex for
long periods.

---------

Signed-off-by: bigsheeper <[email protected]>
issue: #39556

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
issue: #38399

- Embed the query node into streaming node to make delegator available
at streaming node.
- The embedded query node has a special server label
`QUERYNODE_STREAMING-EMBEDDED`.
- Change the balance strategy to make the channel assigned to streaming
node as much as possible.

Signed-off-by: chyezh <[email protected]>
The dsl fields are separated in sub request structs and cannot be
easiliy printed before. This PR adds a log helper to print the dsl
expressions of HybridSearchRequest.

Signed-off-by: Congqi Xia <[email protected]>
Related to #39596

When updating the build param configuration, the `Formatter` could be
used to do so and completed avoid touching the `overlay` config items

---------

Signed-off-by: Congqi Xia <[email protected]>
issue: #38399

- The stats may be kept after wal closing if the growing segment is not
dirty.
- Change the error handling of wal open to avoid redundant manager api
call.

Signed-off-by: chyezh <[email protected]>
…etrics (#39536)

/kind improvement

---------

Signed-off-by: bigsheeper <[email protected]>
)

issue: #39333

---------

Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: cai.zhang <[email protected]>
issue: #38399

- Make the wal scanner interface same with streaming scanner.
- Use wal if the wal is located at current node.
- Otherwise fallback the old logic.

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.