fix: add missing @Id annotation to Problem record - #133
Open
HunarBhatia wants to merge 1 commit into
Open
Conversation
Fixes hardikxk#130 - Problem record was missing @id on the id field - Without @id Spring Data cannot identify the primary key - UserProblem correctly uses @id but Problem was inconsistent
Author
|
@hardikxk Could you please add labels like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130
Problem
The
Problemrecord was missing the@Idannotation on itsidfield. Without@Id, Spring Data has no way to identify the primary key field, which can cause silent failures in repository operations likefindById()and unexpected query behaviour.Compare with
UserProblemwhich correctly uses@Id:Fix
Added
@Idannotation fromorg.springframework.data.annotation.Idto theidfield of theProblemrecord, consistent withUserProblem.File Changed
problems-service/src/main/java/com/hardik/problemsservice/model/Problem.java