fix: Add @Id annotation to Problem record id field - #136
Open
Rohit-code07 wants to merge 2 commits into
Open
Conversation
Author
|
Hi @hardikxk, I have resolved the issue and submitted a PR for it. Kindly review it and merge if everything looks good. Thank you! |
Removed redundant note about avoiding unnecessary dependencies and updated project status section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add Missing
@IdAnnotation inProblemRecordIssue Description
The
Problemrecord inproblems-servicewas missing the@Idannotation on itsidfield. Since Spring Data relies on@Idto identify the primary key, the absence of this annotation could prevent proper entity identification and affect repository operations.Root Cause
Unlike
UserProblem, which correctly defines the identifier field using@Id, theProblemrecord did not explicitly mark its primary key.Before Fix
In this implementation, Spring Data cannot explicitly identify the primary key field.
Changes Made
Added the missing
@Idannotation to theidfield inProblem.java.After Fix
Impact
findById()Files Modified
Related Issue
Fixes #130