-
Notifications
You must be signed in to change notification settings - Fork 82
docs: Do a VM guest shut down if possible #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
votdev
wants to merge
1
commit into
harvester:main
Choose a base branch
from
votdev:issue_7483_shutdown_guest_vm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the VM importer documentation to describe the new graceful shutdown options when importing VMs.
- Adds two new fields, gracefulShutdown and gracefulShutdownTimeout, to the configuration example.
- Updates the documentation text to explain the behavior and default values for these fields and includes a note for OpenStack users.
|
jillian-maroket
previously approved these changes
Apr 23, 2025
ihcsim
previously approved these changes
Apr 23, 2025
Will turning the PR into a draft revert approvals? If not, I suggest making this a draft so people won't accidentally merge it. |
2c8aa5b
to
e8fdbcd
Compare
jillian-maroket
previously approved these changes
Jun 3, 2025
Add info about `forcePowerOff` and `gracefulShutdownTimeoutSeconds`. Related to: harvester/harvester#7483 Signed-off-by: Volker Theile <[email protected]> (cherry picked from commit cf14b33) Signed-off-by: Volker Theile <[email protected]>
e8fdbcd
to
777a5ff
Compare
jillian-maroket
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info about
forcePowerOff
andgracefulShutdownTimeoutSeconds
.Related to: harvester/harvester#7483