Skip to content

docs: Do a VM guest shut down if possible #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

votdev
Copy link
Member

@votdev votdev commented Apr 22, 2025

Add info about forcePowerOff and gracefulShutdownTimeoutSeconds.

Related to: harvester/harvester#7483

@votdev votdev self-assigned this Apr 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the VM importer documentation to describe the new graceful shutdown options when importing VMs.

  • Adds two new fields, gracefulShutdown and gracefulShutdownTimeout, to the configuration example.
  • Updates the documentation text to explain the behavior and default values for these fields and includes a note for OpenStack users.

@votdev
Copy link
Member Author

votdev commented Apr 22, 2025

Successor to #720 (and #755) after it was inadvertently merged.

Copy link

github-actions bot commented Apr 22, 2025

Name Link
🔨 Latest commit 777a5ff
😎 Deploy Preview https://683ecb59b2895c8ddc064437--harvester-preview.netlify.app

ihcsim
ihcsim previously approved these changes Apr 23, 2025
@starbops
Copy link
Member

Will turning the PR into a draft revert approvals? If not, I suggest making this a draft so people won't accidentally merge it.

@votdev votdev marked this pull request as draft June 3, 2025 06:03
@votdev votdev changed the title Do a VM guest shut down if possible docs: Do a VM guest shut down if possible Jun 3, 2025
@votdev votdev dismissed stale reviews from ihcsim and jillian-maroket via 2c8aa5b June 3, 2025 09:32
@votdev votdev force-pushed the issue_7483_shutdown_guest_vm branch 2 times, most recently from 2c8aa5b to e8fdbcd Compare June 3, 2025 09:35
@votdev votdev marked this pull request as ready for review June 3, 2025 09:36
@votdev votdev requested a review from jillian-maroket June 3, 2025 09:37
@github-actions github-actions bot requested a review from akashraj4261 June 3, 2025 09:37
@votdev votdev requested a review from ihcsim June 3, 2025 09:37
jillian-maroket
jillian-maroket previously approved these changes Jun 3, 2025
Add info about `forcePowerOff` and `gracefulShutdownTimeoutSeconds`.

Related to: harvester/harvester#7483

Signed-off-by: Volker Theile <[email protected]>
(cherry picked from commit cf14b33)
Signed-off-by: Volker Theile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants