-
Notifications
You must be signed in to change notification settings - Fork 82
docs: Add more details about http-proxy #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done
Signed-off-by: Vatsal Parekh <[email protected]>
@starbops PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @vatsalparekh. In general, the aspect we want to improve is that users should be able to determine precisely which components, such as pods and system services, will honor these HTTP proxy-related settings by reading through these specific paragraphs. So, it'd be great if you can list down all the components affected.
To achieve this, you might need to trace the source code, as we use a mutator to inject an HTTP proxy-related environment variable into only a set of pods.
Additionally, there is a specific case that we would like to address, as described in the original issue. The key is to set HTTP proxy-related settings when importing the Harvester cluster to the external Rancher Manager. Users typically don't need to modify the Rancher Manager's HTTP proxy setting. These are two different things. It'd be great if we could provide links to the relevant parts in other projects' documentation.
Problem:
harvester/harvester#8337
Improving http proxy related documentation