Skip to content

docs: Add more details about http-proxy #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vatsalparekh
Copy link

Problem:

harvester/harvester#8337

Improving http proxy related documentation

Copy link

github-actions bot commented May 26, 2025

Name Link
🔨 Latest commit aff2f97
😎 Deploy Preview https://684160035361e06ec24b6093--harvester-preview.netlify.app

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

Signed-off-by: Vatsal Parekh <[email protected]>
@jillian-maroket
Copy link
Contributor

@starbops PTAL. Thanks!

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vatsalparekh. In general, the aspect we want to improve is that users should be able to determine precisely which components, such as pods and system services, will honor these HTTP proxy-related settings by reading through these specific paragraphs. So, it'd be great if you can list down all the components affected.

To achieve this, you might need to trace the source code, as we use a mutator to inject an HTTP proxy-related environment variable into only a set of pods.

Additionally, there is a specific case that we would like to address, as described in the original issue. The key is to set HTTP proxy-related settings when importing the Harvester cluster to the external Rancher Manager. Users typically don't need to modify the Rancher Manager's HTTP proxy setting. These are two different things. It'd be great if we could provide links to the relevant parts in other projects' documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants