Upgrade dependencies, tooling, and fix handling of benign CLI exit messages #1082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p message This commit changes the way the pipeline emits errors when clap fails to parse the command line arguments. Instead of treating all "abort"s as fatal errors, we check that the errors from `clap` are not benign before terminating the pipeline with the indication that the pipeline "failed". For example, before hand we would print for `--version`: ``` error: hashc 0.1.0-3c6a02d0ca00b7c14e2e0622bfb724f4dbe68fc2 ``` And after this, we print: ``` info: hashc 0.1.0-3c6a02d0ca00b7c14e2e0622bfb724f4dbe68fc2 ```
…nt stable release
kontheocharis
approved these changes
Dec 8, 2024
Collaborator
kontheocharis
left a comment
kontheocharis
left a comment
There was a problem hiding this comment.
Nice simplification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an aggregation of a few observed issues and improvements. These are:
Adjustments to documentation for several parts, tokenisation and error
reporting.
Upgrade all dependencies
Upgrade to the latest nightly compiler and fix any detected issues by the
accompanying clippy lints.
Fix a CLI cosmetic issue where benign messages such as "help" or "version" were being treated as fatal errors.
Commits
TokenKind::Tree(...)variantnote_on_spanutilitymap_orfor simpler comparison calls#![feature(...)]s that are stabilised on the current stable release