Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rab permissions docs rebase #3458

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Rab permissions docs rebase #3458

wants to merge 21 commits into from

Conversation

stellarsquall
Copy link
Collaborator

This pull request recreates PR #3352.

Restructuring and adding of material and examples to permissions/grants documentation. The goal is to make the permissions concept easier to understand and implement for users.

Dan-Heath and others added 13 commits July 14, 2023 15:44
@stellarsquall stellarsquall added backport/website Backport changes to `stable-website` and the latest release-branch event/boundary-docs-day Boundary Docs Day event labels Jul 14, 2023
@Dan-Heath Dan-Heath added this to the deferred milestone Jul 18, 2023
Dan-Heath
Dan-Heath requested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I added a few suggestions about the hierarchy on the Advanced Concepts page, as well as a couple other minor fixes I noticed. Please let me know if you have any questions or if I can help with anything.

website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/advanced.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/security/permissions/grants.mdx Outdated Show resolved Hide resolved
@Dan-Heath
Copy link
Contributor

Hi @xingluw and @PPacent , I went ahead and applied my suggested edits to this PR and approved. Does it look OK to you? Thanks!

@Dan-Heath Dan-Heath mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingluw xingluw xingluw left review comments

@Dan-Heath Dan-Heath Dan-Heath approved these changes

@covetocove covetocove Awaiting requested review from covetocove

At least 1 approving review is required to merge this pull request.

Assignees

@Dan-Heath Dan-Heath

Labels
backport/website Backport changes to `stable-website` and the latest release-branch docs/concepts event/boundary-docs-day Boundary Docs Day event website
Projects
None yet
Milestone
deferred
Development

Successfully merging this pull request may close these issues.
3 participants
@stellarsquall @Dan-Heath @xingluw