Skip to content

Migrate armon/go-metrics to hashicorp/go-metrics and update Go dependencies#1143

Merged
paras-gupta2 merged 8 commits into
mainfrom
deps/update-go-dependencies
Jun 23, 2026
Merged

Migrate armon/go-metrics to hashicorp/go-metrics and update Go dependencies#1143
paras-gupta2 merged 8 commits into
mainfrom
deps/update-go-dependencies

Conversation

@paras-gupta2

@paras-gupta2 paras-gupta2 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

PCI review checklist

  • Workflows: Added hashicorpmetrics build tag to all CI matrix jobs and to the golangci-lint step in consul-dataplane-checks.yaml
  • Added hashicorp/go-metrics v0.5.4 as a direct dependency; armon/go-metrics demoted to indirect and updated all the dependencies to use the latest versions.
  • Makefile: Added GOTAGS ?= hashicorpmetrics and wired it into the unit-tests target
  • Source files: Updated all import paths in consuldp and metrics-cache from armon/go-metrics to hashicorp/go-metrics

List of backported PRs

@paras-gupta2 paras-gupta2 requested review from a team as code owners June 4, 2026 12:17
@paras-gupta2 paras-gupta2 added backport/all backport/1.8 Changes are backported to 1.8 backport/1.9 Changes are backported to 1.9 labels Jun 4, 2026
@paras-gupta2 paras-gupta2 added the backport/2.0 Changes are backported to 2.0 label Jun 4, 2026
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.28%. Comparing base (7c99930) to head (6019aed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   68.19%   68.28%   +0.08%     
==========================================
  Files          19       19              
  Lines        2182     2188       +6     
==========================================
+ Hits         1488     1494       +6     
  Misses        593      593              
  Partials      101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srahul3 srahul3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/all backport/1.8 Changes are backported to 1.8 backport/1.9 Changes are backported to 1.9 backport/2.0 Changes are backported to 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants