Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/1064.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
- envoy: add `skip_exit` to `drain_listeners` admin API call to prevent premature pod termination when upgrading to Envoy 1.37+
```
2 changes: 1 addition & 1 deletion pkg/envoy/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
// Note: the caller is responsible for ensuring Drain is not called concurrently
// with Run, as this is thread-unsafe.
func (p *Proxy) Drain() error {
envoyDrainListenersUrl := fmt.Sprintf("http://%s:%v/drain_listeners?inboundonly&graceful", p.cfg.AdminAddr, p.cfg.AdminBindPort)
envoyDrainListenersUrl := fmt.Sprintf("http://%s/drain_listeners?inboundonly&graceful&skip_exit", net.JoinHostPort(p.cfg.AdminAddr, strconv.Itoa(p.cfg.AdminBindPort)))

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / integration-tests

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / integration-tests

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / lint

undefined: strconv (typecheck)

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / lint

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / unit-tests

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / unit-tests

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux amd64 build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux amd64 build

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux arm build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux arm build

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux arm64 build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux arm64 build

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 darwin arm64 build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 darwin arm64 build

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 darwin amd64 build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 darwin amd64 build

undefined: net

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux 386 build

undefined: strconv

Check failure on line 180 in pkg/envoy/proxy.go

View workflow job for this annotation

GitHub Actions / Go 1.26.2 linux 386 build

undefined: net
switch p.getState() {
case stateExited:
// Nothing to do!
Expand Down
Loading