Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint to 1.56.1 #22134

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Update golangci-lint to 1.56.1 #22134

merged 1 commit into from
Feb 11, 2025
+1 −1

Conversation

abhishek-hashicorp
Copy link
Contributor

Description

Lint is failing after upgrade to go 1.22.12 and hence updating the golangci-lint to 1.56.1

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@abhishek-hashicorp abhishek-hashicorp requested a review from a team as a code owner February 11, 2025 11:41
@abhishek-hashicorp abhishek-hashicorp added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Feb 11, 2025
nitin-sachdev-29
nitin-sachdev-29 approved these changes Feb 11, 2025
View reviewed changes
Copy link

@nitin-sachdev-29 nitin-sachdev-29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhishek-hashicorp abhishek-hashicorp merged commit 57a39b1 into main Feb 11, 2025
110 of 114 checks passed
@abhishek-hashicorp abhishek-hashicorp deleted the abhishek/fix-lint branch February 11, 2025 12:08
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.20 Changes are backported to 1.20 backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent labels Feb 11, 2025
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Feb 11, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitin-sachdev-29 nitin-sachdev-29 nitin-sachdev-29 approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishek-hashicorp @nitin-sachdev-29 @hc-github-team-consul-core