Skip to content

Add support for nested field indexes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lggomez
Copy link

@lggomez lggomez commented May 17, 2019

Following the examples in the integration tests, I'm talking about nested field accessors of the following form:

"sibling_first": &IndexSchema{
    Name:    "sibling_first",
    Unique:  false,
    Indexer: &NestedStringFieldIndex{Field: "Sibling.First"},
},

Rather than including this behavior as the default in the StringFieldIndex (becasue of the performance penalty of object traversal), I added a separate index type, NestedStringFieldIndex

@hashicorp-cla
Copy link

hashicorp-cla commented May 17, 2019

CLA assistant check
All committers have signed the CLA.

@lggomez lggomez changed the title Add support for nested fields on StringFieldIndex Add support for nested field indexes May 17, 2019
@hbagdi
Copy link
Contributor

hbagdi commented May 17, 2019

Oh nice, this is similiar to https://github.com/hbagdi/deck/blob/master/state/indexers/subFieldIndexer.go

@ekovacs
Copy link

ekovacs commented Apr 9, 2024

will this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants