-
Notifications
You must be signed in to change notification settings - Fork 185
Logger interface #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tehut
wants to merge
6
commits into
hashicorp:master
Choose a base branch
from
tehut:logger_interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Logger interface #105
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cbf6305
swap in logger interface
8e53919
put logger interface on sink structs
b8b3e96
wrap hclog Error function for mulitple args
174dbb5
wrap hc-log errors and comments for CR
tehut 636fae9
typo
tehut 75c41d1
move comments to PR comment
tehut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package logger | ||
|
|
||
| import ( | ||
| log "github.com/hashicorp/go-hclog" | ||
| ) | ||
|
|
||
| // OurLogger implements an empty logger struct to wrap the go-hclog logger | ||
| type OurLogger struct { | ||
| } | ||
|
|
||
| //Logger interface is used to make stuff happen with things in places | ||
| type Logger interface { | ||
| Error(string, ...interface{}) | ||
| } | ||
|
|
||
| // Error wraps the go-hclog Error function and logs a separate error for each argument in the error object passed | ||
| func Error(msg string, l Logger, args ...interface{}) { | ||
| l.Error(msg, "msg", args) | ||
| } | ||
| // ************* [DISCARDED ATTEMPT] ************* | ||
| // fmt.Printf("%v", args) | ||
| // fmt.Println("---") | ||
| // for _, v := range args { | ||
| // l.Error(msg, "msg", v) | ||
| } | ||
|
|
||
| // fmt.Printf("%v", v) | ||
| // fmt.Println("---") | ||
|
|
||
|
|
||
| func (ol *OurLogger) Error(msg string, args ...interface{}) { | ||
| ol.Error(msg, args) | ||
| } | ||
|
|
||
| //New creates and returns a new go-hclog logger | ||
| func (ol *OurLogger) New() Logger { | ||
| l := log.Default() | ||
| return l | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to try keeping a "discarded attempts" section in my code reviews for now. I'll flag them all to be removed before merge but I thought we could try it. I'm hoping it helps me be able to keep track of multiple attempts. Again, may well discard.