Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked deprecation wording for legacy config #5394

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Mar 5, 2019

Made small adjustment to make it clear that 0.8.7 would require the legacy syntax and that the deprecation notice was more about the legacy syntax becoming unsupported at some point after v0.9.0

Made small adjustment to make it clear that 0.8.7 would require the legacy syntax and that the deprecation notice was more about the legacy syntax becoming unsupported at some point after v0.9.0
@angrycub
Copy link
Contributor Author

angrycub commented Mar 5, 2019

Resolves #5390

@angrycub angrycub requested a review from Omar-Khawaja March 5, 2019 22:13
Copy link
Contributor

@Omar-Khawaja Omar-Khawaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for clarifying that bit.

@angrycub angrycub merged commit d75cf58 into master Mar 6, 2019
@angrycub angrycub deleted the doc-raw_exec-deprecation-tweak branch March 6, 2019 16:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants