feat: optional delete of build key vault secret - #645
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
Add build_key_vault_secret_delete so builds that use an externally supplied build_key_vault_name can remove the certificate secret on cleanup, avoiding unbounded secret version growth. Fixes hashicorp#506 Signed-off-by: Aaron Mark <amark@g.jct.ac.il>
amarkdotdev
marked this pull request as ready for review
August 18, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_key_vault_secret_delete(bool) config optionbuild_key_vault_nameis set, delete the certificate secret during step cleanup via the Key Vault data-plane APIFixes #506
Test plan
go test ./builder/azure/arm/ -run StepCertificateInKeyVaultbuild_key_vault_name+build_key_vault_secret_delete = trueand confirm secret is removed after build