fix: align controller names for VBoxManage#178
Open
taraxacum45e9a wants to merge 1 commit intohashicorp:mainfrom
Open
fix: align controller names for VBoxManage#178taraxacum45e9a wants to merge 1 commit intohashicorp:mainfrom
taraxacum45e9a wants to merge 1 commit intohashicorp:mainfrom
Conversation
Update storage controller naming to match the strings used by VBoxManage. The previous names included a redundant "Controller" suffix, and "VirtIO Controller" has been corrected to "VirtioSCSI" to align with VirtualBox device identification. * Replace "IDE Controller" with "IDE" * Replace "SATA Controller" with "SATA" * Replace "SCSI Controller" with "SCSI" * Replace "Floppy Controller" with "Floppy" * Replace "NVMe Controller" with "NVMe" * Replace "VirtIO Controller" with "VirtioSCSI" Fixes: hashicorp#56 Fixes: hashicorp#108 Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the storage controller naming conventions within the VirtualBox plugin to align with the specific strings expected by
VBoxManage.Specifically, this change:
Resolved Issues
Closes #56
Closes #108
Changes to Security Controls
No changes to security controls are included in this PR.