oidc dynamic credential support - #177
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f353d829cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ..., description="Vault address (e.g. https://vault.example.com)" | ||
| ) | ||
| role_name: str = Field(..., alias="role") | ||
| namespace: str | None = None |
There was a problem hiding this comment.
When creating Vault OIDC configurations, namespace is part of the required create payload in the HYOK Vault OIDC API (and go-tfe sends it as a non-omitempty string). Leaving it optional here means callers can construct VaultOIDCConfigurationCreateOptions(address=..., role_name=...), and _build_payload(..., exclude_none=True) will omit namespace, producing a request the server rejects instead of catching the invalid options locally.
Useful? React with 👍 / 👎.
| role_name="hcp-terraform", | ||
| namespace="admin", | ||
| jwt_auth_path="jwt", | ||
| tls_ca_certificate="-----BEGIN CERTIFICATE-----\n...", |
There was a problem hiding this comment.
This example passes a raw PEM block into the field that is serialized as encoded-cacert, but the Vault OIDC API expects that attribute to be a base64-encoded CA certificate. Users copying this for self-hosted Vault with a custom CA will send an invalid value and get a server-side validation error; the example should either base64-encode the PEM first or show an already encoded value.
Useful? React with 👍 / 👎.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 participants
No description provided.