Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use tmccombs/hcl2json and fix go examples #3814

Merged
merged 15 commits into from
Feb 4, 2025
Merged

Conversation

mutahhir
Copy link
Member

Related issue

Fixes #3793

Description

An effort to solve the problems @uluzox was having with their PR by upgrading the go version across all our examples. While the main reason for doing this PR was to see if we can reuse tmccombs/hcl2json instead of our fork, I had to fix a bunch of go examples along the way.

The reason for switching back is written in detail within @uluzox's PR: #3797.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner January 30, 2025 11:42
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team January 30, 2025 11:42
…we use is go 1.18.5, and we cannot upgrade it yet
@mutahhir mutahhir changed the title chore: Upgrade go version to 1.22 and use tmccombs/hcl2json chore: Use tmccombs/hcl2json and fix go examples Feb 4, 2025
@mutahhir mutahhir enabled auto-merge February 4, 2025 10:26
@mutahhir mutahhir added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit f0cfd2f Feb 4, 2025
849 checks passed
@mutahhir mutahhir deleted the chore/upgrade-go branch February 4, 2025 12:02
@uluzox
Copy link

uluzox commented Feb 4, 2025

Hey @mutahhir and @DanielMSchmidt,

Thank you for resolving this issue. When do you think will this change be released?

Kind regards

Copy link
Contributor

github-actions bot commented Mar 7, 2025

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies: use latest version of tmccombs/hcl2json
3 participants