Skip to content

TFECO-9502: chore: update protobuf definitions to include actions rpcs and messages #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented May 20, 2025

Related Issue

Fixes #

Description

Updated the protofbuf definitions based on hashicorp/terraform#37006 – this will probably collide with #512 and I'll rebase this PR once the other one is merged or almost ready. edit: ✅ this branch is now based on #512

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@ansgarm ansgarm force-pushed the actions-protobuf branch 2 times, most recently from d3c5f13 to 3c4cf49 Compare May 21, 2025 09:10
@ansgarm ansgarm changed the base branch from main to rk/list-bindings May 21, 2025 09:10
@ansgarm ansgarm changed the title chore: update protobuf definitions to include actions rpcs and messages TFECO-9502: chore: update protobuf definitions to include actions rpcs and messages May 21, 2025
Base automatically changed from rk/list-bindings to main May 21, 2025 14:10
@ansgarm ansgarm force-pushed the actions-protobuf branch from 3c4cf49 to 5e45df2 Compare May 21, 2025 14:23
@ansgarm
Copy link
Member Author

ansgarm commented May 22, 2025

#512 was reverted so I'll have to rebase this one once more (when that PR is re-reverted :D)

@ansgarm ansgarm force-pushed the actions-protobuf branch from 5e45df2 to 168b7fd Compare May 28, 2025 07:44
@ansgarm
Copy link
Member Author

ansgarm commented May 28, 2025

rebased it onto #522

@ansgarm ansgarm changed the base branch from main to rk/list-protobuf May 28, 2025 07:45
@rainkwan rainkwan force-pushed the rk/list-protobuf branch from dd82eea to 74f8bdc Compare May 28, 2025 15:32
Base automatically changed from rk/list-protobuf to main May 28, 2025 15:49
@ansgarm ansgarm force-pushed the actions-protobuf branch from 1ebdfa6 to e8c485f Compare June 2, 2025 12:53
@ansgarm ansgarm marked this pull request as ready for review June 2, 2025 13:11
@ansgarm ansgarm requested a review from a team as a code owner June 2, 2025 13:11
SBGoods
SBGoods previously approved these changes Jun 2, 2025
SBGoods
SBGoods previously approved these changes Jun 3, 2025
@ansgarm ansgarm force-pushed the actions-protobuf branch from 5adf7f0 to 644e4c6 Compare June 3, 2025 14:11
@ansgarm ansgarm enabled auto-merge (squash) June 3, 2025 14:11
@ansgarm ansgarm disabled auto-merge June 19, 2025 12:21
@ansgarm ansgarm marked this pull request as draft June 19, 2025 12:21
@ansgarm
Copy link
Member Author

ansgarm commented Jun 19, 2025

converted to draft to adjust to latest protocol changes

@ansgarm ansgarm force-pushed the actions-protobuf branch 3 times, most recently from 398b6ba to 19c1ae7 Compare June 19, 2025 13:20
@ansgarm ansgarm marked this pull request as ready for review June 19, 2025 14:03
@ansgarm ansgarm force-pushed the actions-protobuf branch from 19c1ae7 to 5eff9bc Compare June 20, 2025 07:01
Copy link
Contributor

@SBGoods SBGoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants