-
Notifications
You must be signed in to change notification settings - Fork 35
TFECO-9502: chore: update protobuf definitions to include actions rpcs and messages #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ansgarm
wants to merge
4
commits into
main
Choose a base branch
from
actions-protobuf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3c5f13
to
3c4cf49
Compare
#512 was reverted so I'll have to rebase this one once more (when that PR is re-reverted :D) |
rebased it onto #522 |
dd82eea
to
74f8bdc
Compare
SBGoods
previously approved these changes
Jun 2, 2025
SBGoods
previously approved these changes
Jun 3, 2025
converted to draft to adjust to latest protocol changes |
398b6ba
to
19c1ae7
Compare
19c1ae7
to
5eff9bc
Compare
SBGoods
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #
Description
Updated the protofbuf definitions based on hashicorp/terraform#37006 – this will probably collide with #512 and I'll rebase this PR once the other one is merged or almost ready. edit: ✅ this branch is now based on #512
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.