actions interfaces #523
Closed
actions interfaces #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
actions-interfaces
branch
2 times, most recently
from
0a764fe to
7cf4de1
Compare
ansgarm
commented
May 28, 2025
|
|
||
| var _ tfprotov5.InvokeActionStreamingServer = InvokeActionStreamingServerImpl{} | ||
|
|
||
| type InvokeActionStreamingServerImpl struct { |
There was a problem hiding this comment.
unsure if Impl smells too much like Java 😆
ansgarm
force-pushed
the
actions-interfaces
branch
from
5a3c44d to
2fd5567
Compare
ansgarm
force-pushed
the
actions-protobuf
branch
4 times, most recently
from
19c1ae7 to
5eff9bc
Compare
austinvalle
force-pushed
the
actions-protobuf
branch
from
b621e6b to
f4d2964
Compare
|
The protocol has shifted a little and I think we're going to take an approach similar to the list implementation (very similar to this) using iterators/range over functions, so I'm gonna close and re-open a new PR 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.