Skip to content

New Resource aws_nat_gateway_eip_association #42591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented May 13, 2025

Description

New resource aws_nat_gateway_eip_association to manage associations separately making it possible to delete aws_eip resources that would previously fail as the aws_nat_gateway resource would not update first to release the association.

Relations

References

Relates to: terraform-aws-modules/terraform-aws-vpc#1005

Output from Acceptance Testing

%   make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCNATGatewayEIPAssociation_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCNATGatewayEIPAssociation_'  -timeout 360m -vet=off
2025/05/13 16:47:49 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCNATGatewayEIPAssociation_basic
=== PAUSE TestAccVPCNATGatewayEIPAssociation_basic
=== RUN   TestAccVPCNATGatewayEIPAssociation_disappears
=== PAUSE TestAccVPCNATGatewayEIPAssociation_disappears
=== CONT  TestAccVPCNATGatewayEIPAssociation_basic
=== CONT  TestAccVPCNATGatewayEIPAssociation_disappears
--- PASS: TestAccVPCNATGatewayEIPAssociation_disappears (546.77s)
--- PASS: TestAccVPCNATGatewayEIPAssociation_basic (573.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        578.214s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels May 13, 2025
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2025
@drewtul drewtul marked this pull request as ready for review May 13, 2025 18:25
@drewtul drewtul requested a review from a team as a code owner May 13, 2025 18:25
@drewtul
Copy link
Contributor Author

drewtul commented May 13, 2025

One error in the checks to a a wait function that I just added ContinuousTargetOccurence to about the return value not being used, I could remove it, but it currently follows the general signature of wait functions.

@drewtul drewtul changed the title New Resource vpc_nat_gateway_eip_association New Resource aws_nat_gateway_eip_association May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants