Skip to content

[Enhancement] aws_glue_job: Add job_mode argument #42607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented May 13, 2025

Description

  • Added job_mode argument to aws_glue_job

Relations

Closes #42601

References

https://docs.aws.amazon.com/glue/latest/webapi/API_CreateJob.html#Glue-CreateJob-request-JobMode

Output from Acceptance Testing

$ make testacc TESTS=TestAccGlueJob_ PKG=glue 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m -vet=off
2025/05/14 08:33:47 Initializing Terraform AWS Provider...
=== RUN   TestAccGlueJob_basic
=== PAUSE TestAccGlueJob_basic
=== RUN   TestAccGlueJob_disappears
=== PAUSE TestAccGlueJob_disappears
=== RUN   TestAccGlueJob_basicStreaming
=== PAUSE TestAccGlueJob_basicStreaming
=== RUN   TestAccGlueJob_command
=== PAUSE TestAccGlueJob_command
=== RUN   TestAccGlueJob_defaultArguments
=== PAUSE TestAccGlueJob_defaultArguments
=== RUN   TestAccGlueJob_nonOverridableArguments
=== PAUSE TestAccGlueJob_nonOverridableArguments
=== RUN   TestAccGlueJob_description
=== PAUSE TestAccGlueJob_description
=== RUN   TestAccGlueJob_glueVersion
=== PAUSE TestAccGlueJob_glueVersion
=== RUN   TestAccGlueJob_executionClass
=== PAUSE TestAccGlueJob_executionClass
=== RUN   TestAccGlueJob_executionProperty
=== PAUSE TestAccGlueJob_executionProperty
=== RUN   TestAccGlueJob_jobRunQueuingEnabled
=== PAUSE TestAccGlueJob_jobRunQueuingEnabled
=== RUN   TestAccGlueJob_maintenanceWindow
=== PAUSE TestAccGlueJob_maintenanceWindow
=== RUN   TestAccGlueJob_maxRetries
=== PAUSE TestAccGlueJob_maxRetries
=== RUN   TestAccGlueJob_notificationProperty
=== PAUSE TestAccGlueJob_notificationProperty
=== RUN   TestAccGlueJob_tags
=== PAUSE TestAccGlueJob_tags
=== RUN   TestAccGlueJob_streamingTimeout
=== PAUSE TestAccGlueJob_streamingTimeout
=== RUN   TestAccGlueJob_timeout
=== PAUSE TestAccGlueJob_timeout
=== RUN   TestAccGlueJob_security
=== PAUSE TestAccGlueJob_security
=== RUN   TestAccGlueJob_workerType
=== PAUSE TestAccGlueJob_workerType
=== RUN   TestAccGlueJob_pythonShell
=== PAUSE TestAccGlueJob_pythonShell
=== RUN   TestAccGlueJob_rayJob
=== PAUSE TestAccGlueJob_rayJob
=== RUN   TestAccGlueJob_maxCapacity
=== PAUSE TestAccGlueJob_maxCapacity
=== RUN   TestAccGlueJob_sourceControlDetails
=== PAUSE TestAccGlueJob_sourceControlDetails
=== RUN   TestAccGlueJob_jobMode
=== PAUSE TestAccGlueJob_jobMode
=== CONT  TestAccGlueJob_basic
=== CONT  TestAccGlueJob_maxRetries
=== CONT  TestAccGlueJob_workerType
=== CONT  TestAccGlueJob_jobMode
=== CONT  TestAccGlueJob_sourceControlDetails
=== CONT  TestAccGlueJob_maxCapacity
=== CONT  TestAccGlueJob_rayJob
=== CONT  TestAccGlueJob_pythonShell
=== CONT  TestAccGlueJob_description
=== CONT  TestAccGlueJob_maintenanceWindow
=== CONT  TestAccGlueJob_jobRunQueuingEnabled
=== CONT  TestAccGlueJob_executionProperty
=== CONT  TestAccGlueJob_executionClass
=== CONT  TestAccGlueJob_glueVersion
=== CONT  TestAccGlueJob_streamingTimeout
=== CONT  TestAccGlueJob_security
=== CONT  TestAccGlueJob_timeout
=== CONT  TestAccGlueJob_tags
=== CONT  TestAccGlueJob_notificationProperty
=== CONT  TestAccGlueJob_nonOverridableArguments
--- PASS: TestAccGlueJob_rayJob (49.59s)
=== CONT  TestAccGlueJob_basicStreaming
--- PASS: TestAccGlueJob_maintenanceWindow (49.67s)
=== CONT  TestAccGlueJob_defaultArguments
--- PASS: TestAccGlueJob_basic (58.98s)
=== CONT  TestAccGlueJob_disappears
--- PASS: TestAccGlueJob_description (79.91s)
=== CONT  TestAccGlueJob_command
--- PASS: TestAccGlueJob_timeout (82.57s)
--- PASS: TestAccGlueJob_security (86.19s)
--- PASS: TestAccGlueJob_maxRetries (89.25s)
--- PASS: TestAccGlueJob_jobRunQueuingEnabled (89.36s)
--- PASS: TestAccGlueJob_executionClass (89.42s)
--- PASS: TestAccGlueJob_maxCapacity (89.74s)
--- PASS: TestAccGlueJob_nonOverridableArguments (89.79s)
--- PASS: TestAccGlueJob_sourceControlDetails (89.79s)
--- PASS: TestAccGlueJob_jobMode (89.81s)
--- PASS: TestAccGlueJob_executionProperty (90.38s)
--- PASS: TestAccGlueJob_notificationProperty (90.40s)
--- PASS: TestAccGlueJob_streamingTimeout (90.41s)
--- PASS: TestAccGlueJob_disappears (35.67s)
--- PASS: TestAccGlueJob_basicStreaming (45.17s)
--- PASS: TestAccGlueJob_glueVersion (98.73s)
--- PASS: TestAccGlueJob_tags (105.05s)
--- PASS: TestAccGlueJob_defaultArguments (59.67s)
--- PASS: TestAccGlueJob_pythonShell (121.85s)
--- PASS: TestAccGlueJob_command (44.65s)
--- PASS: TestAccGlueJob_workerType (128.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       133.150s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. labels May 13, 2025
@tabito-hara tabito-hara marked this pull request as ready for review May 14, 2025 00:02
@tabito-hara tabito-hara requested a review from a team as a code owner May 14, 2025 00:02
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JobMode parameter for Glue Jobs
2 participants