-
Notifications
You must be signed in to change notification settings - Fork 9.5k
d/aws_iam_service_linked_role: new data source can ensure the role exists #42659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexbacchin
wants to merge
5
commits into
hashicorp:main
Choose a base branch
from
alexbacchin:f-iam-service-linked-role-datasource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
d/aws_iam_service_linked_role: new data source can ensure the role exists #42659
alexbacchin
wants to merge
5
commits into
hashicorp:main
from
alexbacchin:f-iam-service-linked-role-datasource
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
external-maintainer
Contribution from a trusted external contributor.
generators
Relates to code generators.
new-data-source
Introduces a new data source.
service/iam
Issues and PRs that pertain to the iam service.
size/XL
Managed by automation to categorize the size of a PR.
sweeper
Pertains to changes to or issues with the sweeper.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New data source:
Description
This data source returns a service linked role but also can ensure its existence via attribute
create_if_missing
. It will call the create the IAM Service Linked role (in case does not exist) before exporting the data.This ensure consistence either on existing accounts when the role was previously created or new deployments where the role does not yet exist.
The #29318 has the detailed discussion to back this. In summary, service linked roles can be created either by
aws_iam_service_linked_role
resource, AWS CLI or AWS itself when a service is invoked. It makes difficult to maintain modules that include theaws_iam_service_linked_role
resource.The
import
is a viable option is some scenarios, but not practical when 2 modules need this to ensure this role is present.Relations
Relates: #39441 (I raised the PR few months ago but made a mistake and it was closed)
Closes #29318
Relates: hashicorp/terraform#33633
References
Output from Acceptance Testing