Skip to content

feat: add tags implementation #42663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stefanfreitag
Copy link
Contributor

@stefanfreitag stefanfreitag commented May 18, 2025

Description

Add tagging support for resource aws_verifiedpermissions_policy_store and its data-source equivalent.
(Disclaimer: First time I am working on the tags)

Relations

Closes #42517

References

Output from Acceptance Testing

Resource

$ make testacc TESTS=TestAccVerifiedPermissionsPolicyStore_basic PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStore_basic'  -timeout 360m -vet=off
2025/05/18 19:54:35 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedPermissionsPolicyStore_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStore_basic
=== CONT  TestAccVerifiedPermissionsPolicyStore_basic
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (24.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        24.458s
$ make testacc TESTS=TestAccVerifiedPermissionsPolicyStore_tags PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStore_tags'  -timeout 360m -vet=off
2025/05/18 20:00:12 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedPermissionsPolicyStore_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStore_tags
=== CONT  TestAccVerifiedPermissionsPolicyStore_tags
--- PASS: TestAccVerifiedPermissionsPolicyStore_tags (53.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        53.225s

Data-Source

$ make testacc TESTS=TestAccVerifiedPermissionsPolicyStoreDataSource_basic PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStoreDataSource_basic'  -timeout 360m -vet=off
2025/05/19 21:27:07 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_basic
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (22.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        22.302s

$ make testacc TESTS=TestAccVerifiedPermissionsPolicyStoreDataSource_tags PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStoreDataSource_tags'  -timeout 360m -vet=off
2025/05/19 21:28:28 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_tags
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_tags (21.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        22.014s
´``

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/L Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels May 18, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2025
@stefanfreitag stefanfreitag marked this pull request as ready for review May 19, 2025 16:26
@stefanfreitag stefanfreitag requested a review from a team as a code owner May 19, 2025 16:26
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 20, 2025
@ewbankkit ewbankkit self-assigned this May 20, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedPermissionsPolicyStore_\|TestAccVerifiedPermissionsPolicyStoreDataSource_' PKG=verifiedpermissions ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 3  -run=TestAccVerifiedPermissionsPolicyStore_\|TestAccVerifiedPermissionsPolicyStoreDataSource_ -timeout 360m -vet=off
2025/05/20 09:50:48 Initializing Terraform AWS Provider...
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== RUN   TestAccVerifiedPermissionsPolicyStore_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStore_basic
=== RUN   TestAccVerifiedPermissionsPolicyStore_update
=== PAUSE TestAccVerifiedPermissionsPolicyStore_update
=== RUN   TestAccVerifiedPermissionsPolicyStore_disappears
=== PAUSE TestAccVerifiedPermissionsPolicyStore_disappears
=== RUN   TestAccVerifiedPermissionsPolicyStore_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStore_tags
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== CONT  TestAccVerifiedPermissionsPolicyStore_update
=== CONT  TestAccVerifiedPermissionsPolicyStore_basic
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (11.72s)
=== CONT  TestAccVerifiedPermissionsPolicyStore_tags
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (13.27s)
=== CONT  TestAccVerifiedPermissionsPolicyStore_disappears
--- PASS: TestAccVerifiedPermissionsPolicyStore_update (18.30s)
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_tags
--- PASS: TestAccVerifiedPermissionsPolicyStore_disappears (10.31s)
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_tags (10.51s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_tags (27.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions	43.645s

@ewbankkit
Copy link
Contributor

@stefanfreitag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3fcffa7 into hashicorp:main May 20, 2025
46 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.99.0 milestone May 20, 2025
@stefanfreitag stefanfreitag deleted the f-aws_verifiedpermissions_policy_store-add-tag-support branch May 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_verifiedpermissions_policy_store: Add tags
4 participants