-
Notifications
You must be signed in to change notification settings - Fork 9.5k
feat: add tags implementation #42663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tags implementation #42663
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVerifiedPermissionsPolicyStore_\|TestAccVerifiedPermissionsPolicyStoreDataSource_' PKG=verifiedpermissions ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 3 -run=TestAccVerifiedPermissionsPolicyStore_\|TestAccVerifiedPermissionsPolicyStoreDataSource_ -timeout 360m -vet=off
2025/05/20 09:50:48 Initializing Terraform AWS Provider...
=== RUN TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== RUN TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== RUN TestAccVerifiedPermissionsPolicyStore_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStore_basic
=== RUN TestAccVerifiedPermissionsPolicyStore_update
=== PAUSE TestAccVerifiedPermissionsPolicyStore_update
=== RUN TestAccVerifiedPermissionsPolicyStore_disappears
=== PAUSE TestAccVerifiedPermissionsPolicyStore_disappears
=== RUN TestAccVerifiedPermissionsPolicyStore_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStore_tags
=== CONT TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== CONT TestAccVerifiedPermissionsPolicyStore_update
=== CONT TestAccVerifiedPermissionsPolicyStore_basic
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (11.72s)
=== CONT TestAccVerifiedPermissionsPolicyStore_tags
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (13.27s)
=== CONT TestAccVerifiedPermissionsPolicyStore_disappears
--- PASS: TestAccVerifiedPermissionsPolicyStore_update (18.30s)
=== CONT TestAccVerifiedPermissionsPolicyStoreDataSource_tags
--- PASS: TestAccVerifiedPermissionsPolicyStore_disappears (10.31s)
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_tags (10.51s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_tags (27.34s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions 43.645s
@stefanfreitag Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Description
Add tagging support for resource
aws_verifiedpermissions_policy_store
and its data-source equivalent.(Disclaimer: First time I am working on the tags)
Relations
Closes #42517
References
Output from Acceptance Testing
Resource
Data-Source