-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Implement VPC configuration for AWS Kendra data source #42672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elia-bracci-hs
wants to merge
3
commits into
hashicorp:main
Choose a base branch
from
elia-bracci-hs:f-ebracci-kendra-data-source-vpc-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement VPC configuration for AWS Kendra data source #42672
elia-bracci-hs
wants to merge
3
commits into
hashicorp:main
from
elia-bracci-hs:f-ebracci-kendra-data-source-vpc-configuration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d tests. Add schema support for VPC configuration, including security group and subnet IDs. Enhance resource creation, reading, and updating functions to handle VPC settings.
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
…on signatures to use `types.DataSourceVpcConfiguration` instead of `awstypes.VpcConfiguration` for improved clarity and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Requests to existing resources that expand the functionality or scope.
service/kendra
Issues and PRs that pertain to the kendra service.
size/L
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds support for specifying security_group_ids and subnet_ids via a vpc_configuration block in the aws_kendra_data_source resource. Updates schema and resource logic to handle create, read, and update operations with VPC settings.
Impact:
Enables Kendra data sources to connect to resources in a VPC. Backward-compatible with existing configurations.
Relations
Issues #42670
References
https://docs.aws.amazon.com/cli/latest/reference/kendra/create-data-source.html
Output from Acceptance Testing