Skip to content

Implement VPC configuration for AWS Kendra data source #42672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elia-bracci-hs
Copy link

@elia-bracci-hs elia-bracci-hs commented May 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds support for specifying security_group_ids and subnet_ids via a vpc_configuration block in the aws_kendra_data_source resource. Updates schema and resource logic to handle create, read, and update operations with VPC settings.

Impact:
Enables Kendra data sources to connect to resources in a VPC. Backward-compatible with existing configurations.

Relations

Issues #42670

References

https://docs.aws.amazon.com/cli/latest/reference/kendra/create-data-source.html

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

…d tests. Add schema support for VPC configuration, including security group and subnet IDs. Enhance resource creation, reading, and updating functions to handle VPC settings.
@elia-bracci-hs elia-bracci-hs requested a review from a team as a code owner May 19, 2025 14:02
@elia-bracci-hs elia-bracci-hs marked this pull request as draft May 19, 2025 14:02
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 19, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kendra Issues and PRs that pertain to the kendra service. size/L Managed by automation to categorize the size of a PR. labels May 19, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2025
…on signatures to use `types.DataSourceVpcConfiguration` instead of `awstypes.VpcConfiguration` for improved clarity and consistency.
@elia-bracci-hs elia-bracci-hs marked this pull request as ready for review May 20, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kendra Issues and PRs that pertain to the kendra service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants