Skip to content

Add new aws_workspaces_pool resource and data source #42678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JaydonSunley
Copy link
Contributor

This adds new resource & datasource aws_workspaces_pool.

Relations

Closes #38823

References

Output from Acceptance Testing

% make testacc PKG=workspaces TESTS='TestAccWorkSpacesDataSource_serial/Pool|TestAccWorkSpaces_serial/Pool'
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/workspaces/... -v -count 1 -parallel 20 -run='TestAccWorkSpacesDataSource_serial/Pool|TestAccWorkSpaces_serial/Pool'  -timeout 360m -vet=off
2025/05/20 22:03:29 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== RUN   TestAccWorkSpaces_serial
=== PAUSE TestAccWorkSpaces_serial
=== CONT  TestAccWorkSpacesDataSource_serial
=== CONT  TestAccWorkSpaces_serial
=== RUN   TestAccWorkSpacesDataSource_serial/Pool
=== RUN   TestAccWorkSpaces_serial/Pool
=== RUN   TestAccWorkSpacesDataSource_serial/Pool/basic
=== RUN   TestAccWorkSpaces_serial/Pool/basic
=== PAUSE TestAccWorkSpacesDataSource_serial/Pool/basic
=== CONT  TestAccWorkSpacesDataSource_serial/Pool/basic
=== PAUSE TestAccWorkSpaces_serial/Pool/basic
=== RUN   TestAccWorkSpaces_serial/Pool/disappears
=== PAUSE TestAccWorkSpaces_serial/Pool/disappears
=== RUN   TestAccWorkSpaces_serial/Pool/ApplicationSettings
=== PAUSE TestAccWorkSpaces_serial/Pool/ApplicationSettings
=== RUN   TestAccWorkSpaces_serial/Pool/TimeoutSettings
=== PAUSE TestAccWorkSpaces_serial/Pool/TimeoutSettings
=== RUN   TestAccWorkSpaces_serial/Pool/TimeoutSettings_maxUserDurationInSeconds
=== PAUSE TestAccWorkSpaces_serial/Pool/TimeoutSettings_maxUserDurationInSeconds
=== CONT  TestAccWorkSpaces_serial/Pool/basic
=== CONT  TestAccWorkSpaces_serial/Pool/TimeoutSettings
=== CONT  TestAccWorkSpaces_serial/Pool/ApplicationSettings
=== CONT  TestAccWorkSpaces_serial/Pool/disappears
=== CONT  TestAccWorkSpaces_serial/Pool/TimeoutSettings_maxUserDurationInSeconds
--- PASS: TestAccWorkSpacesDataSource_serial (126.13s)
    --- PASS: TestAccWorkSpacesDataSource_serial/Pool (0.00s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Pool/basic (126.13s)
--- PASS: TestAccWorkSpaces_serial (166.02s)
    --- PASS: TestAccWorkSpaces_serial/Pool (0.00s)
        --- PASS: TestAccWorkSpaces_serial/Pool/TimeoutSettings_maxUserDurationInSeconds (120.77s)
        --- PASS: TestAccWorkSpaces_serial/Pool/basic (127.46s)
        --- PASS: TestAccWorkSpaces_serial/Pool/TimeoutSettings (145.19s)
        --- PASS: TestAccWorkSpaces_serial/Pool/ApplicationSettings (149.19s)
        --- PASS: TestAccWorkSpaces_serial/Pool/disappears (166.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	171.397s
...

@JaydonSunley JaydonSunley requested a review from a team as a code owner May 20, 2025 10:08
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 20, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/workspaces Issues and PRs that pertain to the workspaces service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels May 20, 2025
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Workspace pool
2 participants