Skip to content

F datasource vpclattice service network service associations #42680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yfauser
Copy link
Contributor

@yfauser yfauser commented May 20, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes

Description

Relations

Relates #41398

References

ListServiceNetworkServiceAssociations API
ServiceNetworkServiceAssociationsSummary

Once this PR was reviewed and accepted, I will work on the other four datasources that are requested in Issue #41398.

Output from Acceptance Testing

make testacc TESTS=TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource PKG=vpclattice
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.9 test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource'  -timeout 360m -vet=off
2025/05/20 11:29:20 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource_basic
=== PAUSE TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource_basic
=== CONT  TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource_basic
--- PASS: TestAccVPCLatticeServiceNetworkServiceAssociationsDataSource_basic (54.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 61.328s
...

@yfauser yfauser requested a review from a team as a code owner May 20, 2025 11:27
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 20, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. labels May 20, 2025
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants